[orchagent] Arm 32-bit arch compilation warning Fixes #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sabareesh Kumar Anandan <[email protected]>
qiluo-msft
reviewed
Nov 9, 2020
orchagent/mirrororch.cpp
Outdated
| @@ -748,7 +748,7 @@ bool MirrorOrch::setUnsetPortMirror(Port port, | |||
| if (set) | |||
| { | |||
| port_attr.value.objlist.count = 1; | |||
| port_attr.value.objlist.list = (long unsigned int *)calloc(port_attr.value.objlist.count, sizeof(sai_object_id_t)); | |||
| port_attr.value.objlist.list = reinterpret_cast<sai_object_id_t *>((void *)calloc(port_attr.value.objlist.count, sizeof(sai_object_id_t))); | |||
There was a problem hiding this comment.
calloc [](start = 83, length = 6)
calloc already returns a void *. Why you need to convert explicitly?
There was a problem hiding this comment.
reinterpret cast reports error if we don't explicitly type cast
There was a problem hiding this comment.
I mean why convert calloc to void *. It is already void *.
There was a problem hiding this comment.
removed explicit cast
Signed-off-by: Sabareesh Kumar Anandan <[email protected]>
qiluo-msft
approved these changes
Nov 10, 2020
daall
pushed a commit
to daall/sonic-swss
that referenced
this pull request
Dec 7, 2020
**What I did** Replaced %l variants with PRI format specifier to fix compilation warnings for arm 32-bit arch **How I verified it** Compiled and verified for arm 32-bit arch (marvell-armhf) * [orchagent] Arm 32-bit arch compilation warning Fixes * [orchagent] removed explicit type cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sabareesh Kumar Anandan [email protected]
What I did
Replaced %l variants with PRI format specifier to fix compilation warnings for arm 32-bit arch
Why I did it
How I verified it
Compiled and verified for arm 32-bit arch (marvell-armhf)
Details if related