[FPMSYNCD/FDBSYNCD] EVPN Type-5 route removing prefix-len for host route and removing junk character present in the mac #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is delete from common library, so delete the call as well
Address the review comments
Updated based on review comments
Updated based on the comment
comment from Qi.
MAC in the kernel and due to this mac programming to kernel is failing"
like default-vrf ro vrf route host route doesn't has prefix len while installing into APP_DB, Hence removing the prefix len for host route in case of EVPN route as well.
prsunny
reviewed
Dec 16, 2020
prsunny
approved these changes
Dec 18, 2020
kishorekunal01
changed the title
kishorekunal01
changed the title
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
These issues are only seen on secureboot enabled platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FPMSYNCD/FDBSYNCD]
To make EVPN prefix route inline with the existing code, removing the prefix-len for host routes(/32 and /128).
Some Junk character are present in the mac and port name while config MAC in the kernel.
What I did
If the prefix is a host route don't append the prefix-len while creating the prefix.
With the review comment fix one place memset was removed due to this MAC and port name is containing trailing junk character. Due to this MAC and port name has some Junk character and Kernel is returning error.
Why I did it
Remove the prefix-len for host-routes (/32 & /128)
Removed junk char while installing the FDB entry into Kernel
How I verified it
Verified using vsonic
Signed-off-by: Kishore Kunal [email protected]