Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mux] VS test for neigh, route and fdb #1656

Merged
merged 6 commits into from
Mar 7, 2021
Merged

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Mar 1, 2021

What I did

VS test to cover:

  1. IPv4 and V6 neighbor add and simulate mux state change. Verify: Active mux shall have host entry, Standby mux shall have tunnel route
  2. Route add and simulate mux state change. Verify: Route should have next hop programmed based on mux state (Active shall have neighbor NH, standby shall have tunnel NH)
  3. ECMP route add and simulate mux state change. Verify: ECMP group shall be updated based on mux state change, active mux shall have regular nexthop member, standby shall have tunnel nexthop member
  4. Neighbor handing based on FDB learnt. Verify: Neighbor with FDB learnt on active mux shall have host entry whereas on standby mux shall have tunnel route

Why I did it
unit-test

How I verified it

Run pytest test_mux.py --dvsname=vs --forcedvs

Details if related

@prsunny prsunny requested review from lguohan and daall March 1, 2021 05:15
@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2021

This pull request introduces 5 alerts when merging 91acb6f into 1d33881 - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 2 for Variable defined multiple times

tests/test_mux.py Outdated Show resolved Hide resolved
tests/test_mux.py Outdated Show resolved Hide resolved
tests/test_mux.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2021

This pull request introduces 1 alert when merging 1df6ab2 into b6db9dd - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@prsunny prsunny merged commit 03a0e21 into sonic-net:master Mar 7, 2021
@prsunny prsunny deleted the mux_pytest branch March 7, 2021 20:17
daall pushed a commit that referenced this pull request Mar 19, 2021
VS test to cover:
IPv4 and V6 neighbor add and simulate mux state change. 
Route add and simulate mux state change. 
ECMP route add and simulate mux state change.
Neighbor handing based on FDB learnt.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
VS test to cover:
IPv4 and V6 neighbor add and simulate mux state change. 
Route add and simulate mux state change. 
ECMP route add and simulate mux state change.
Neighbor handing based on FDB learnt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants