Make changes to support compiling on Bullseye with GCC 10 #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types of changes done: * Add missing includes in header files and .cpp files * Don't use parentheses when doing list initialization in constructors * Make sure variables are initialized before first use Signed-off-by: Saikrishna Arcot <[email protected]>
lguohan
approved these changes
Apr 1, 2022
qiluo-msft
reviewed
Apr 1, 2022
| @@ -465,7 +465,7 @@ bool RouteOrch::addLabelRoute(LabelRouteBulkContext& ctx, const NextHopGroupKey | |||
| Label& label = ctx.label; | |||
|
|
|||
| /* next_hop_id indicates the next hop id or next hop group id of this route */ | |||
| sai_object_id_t next_hop_id; | |||
| sai_object_id_t next_hop_id = SAI_NULL_OBJECT_ID; | |||
There was a problem hiding this comment.
Seems a valid bug fix. If true, let's backport to other branches. And better to have a separate PR just for it.
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AidanCopeland
pushed a commit
to Metaswitch/sonic-swss
that referenced
this pull request
Apr 28, 2022
…2216) Types of changes done: * Add missing includes in header files and .cpp files * Don't use parentheses when doing list initialization in constructors * Make sure variables are initialized before first use Signed-off-by: Saikrishna Arcot <[email protected]>
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
…2216) Types of changes done: * Add missing includes in header files and .cpp files * Don't use parentheses when doing list initialization in constructors * Make sure variables are initialized before first use Signed-off-by: Saikrishna Arcot <[email protected]>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…2216) Types of changes done: * Add missing includes in header files and .cpp files * Don't use parentheses when doing list initialization in constructors * Make sure variables are initialized before first use Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saikrishna Arcot [email protected]
What I did
Types of changes done:
Why I did it
Support building swss on Bullseye, so that containers can upgrade to Bullseye.
How I verified it
Not tested at this time, since there's no containers being built for Bullseye yet.
Details if related