Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][202012] Use correct branch when downloading artifact. #2345

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Jun 22, 2022

What I did
Cherry-pick some pipeline related PRs:
4d6fa42 [ci] Change artifact reference pipeline to common lib pipeline. (#2294)
d7b5ff7 [ci] Use correct branch when downloading artifact. (#2292)
2f13244 [ci] Improve azp trigger settings to automaticlly support new release branch. (#2289)
Why I did it

How I verified it

Details if related

@liushilongbuaa liushilongbuaa marked this pull request as ready for review June 22, 2022 08:43
@liushilongbuaa liushilongbuaa requested a review from prsunny June 22, 2022 08:43
@liushilongbuaa
Copy link
Contributor Author

@prsunny , please help review.
These changes are cherry-picked from master branch.

@liushilongbuaa liushilongbuaa changed the title [ci] cherry-pick some pipeline related PRs. [ci][202012] cherry-pick some pipeline related PRs. Jun 22, 2022
@liushilongbuaa liushilongbuaa changed the title [ci][202012] cherry-pick some pipeline related PRs. [ci][202012] Use correct branch when downloading artifact. Jun 22, 2022
@prsunny
Copy link
Collaborator

prsunny commented Jun 22, 2022

i see that 202012 PRs are currently passing. So do we really need this for 202012?

@liushilongbuaa liushilongbuaa merged commit aa6f855 into sonic-net:202012 Jun 23, 2022
@liushilongbuaa
Copy link
Contributor Author

i see that 202012 PRs are currently passing. So do we really need this for 202012?

It's better to keep pipeline the same. If we don't cherry pick, it will be hard to cherry-pick pipeline related PRs in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants