[Portsorch]: The mtu configuration on the port cannot be updated if the fec configuration is blank #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c configuration is blank" This reverts commit 6ce6d90.
…he fec configuration is blank
stcheng
approved these changes
Apr 18, 2018
praveen-li
pushed a commit
to praveen-li/sonic-swss
that referenced
this pull request
Aug 24, 2020
…he fec configuration is blank (sonic-net#468)
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Roman Kachur <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* ARM32 bit fixes, for 64bit printf format specifier Signed-off-by: Antony Rheneus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Save the value once the mtu configuration of the port is set successfully.
Why I did it
Based on the current logic, if the fec configuration is empty or the fec configuration setting fails, the mtu configuration cannot be saved.
How I verified it
Through the code logic.
Details if related