Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][multi asic] show ip bgp summary changes for bgp mon #1483

Merged
merged 6 commits into from
Mar 6, 2021

Conversation

arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Mar 5, 2021

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]

What I did

The sonic-net/sonic-buildimage#6920 adds support of adding BGP monitor session on one of the backend ASICs of Multi ASIC platforms.
This PR enchances the show ip bgp summary command to display this session

Also added unit tests for 'show ip bgp summary' for multi asic platforms

How I did it

Change the bgp_run_command function to look at session of the all the namespaces.

How to verify it

admin@sonic:~$ show ip bgp summary

IPv4 Unicast Summary:
asic0: BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12766
asic1: BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12920
asic2: BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 7994
asic3: BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 9483
asic4: BGP router identifier 8.0.0.4, local AS number 65100 vrf-id 0
BGP table version 8536
asic5: BGP router identifier 8.0.0.5, local AS number 65100 vrf-id 0
BGP table version 8890
RIB entries 77558, using 14270672 bytes of memory
Peers 41, using 857720 KiB of memory
Peer groups 21, using 1344 bytes of memory


Neighbhor      V     AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down    State/PfxRcd    NeighborName
-----------  ---  -----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------
10.0.0.1       4  65200       4312       1171         0      0       0  18:42:48   6370            ARISTA01T2
10.0.0.5       4  65200       4312       1171         0      0       0  18:42:47   6370            ARISTA03T2
10.0.0.9       4  65200       4312       1171         0      0       0  18:42:48   6370            ARISTA05T2
10.0.0.13      4  65200       4313       1168         0      0       0  18:42:45   6370            ARISTA07T2
10.0.0.33      4  64001       1128       4814         0      0       0  18:42:47   33              ARISTA01T0
10.0.0.35      4  64002       1128       4814         0      0       0  18:42:47   33              ARISTA02T0
10.0.0.37      4  64003       1129       4814         0      0       0  18:42:47   34              ARISTA03T0
10.0.0.39      4  64004       1128       4814         0      0       0  18:42:47   33              ARISTA04T0
10.0.0.41      4  64005       1129       4814         0      0       0  18:42:47   34              ARISTA05T0
10.0.0.43      4  64006       1128       4814         0      0       0  18:42:47   33              ARISTA06T0
10.0.0.45      4  64007       1128       4814         0      0       0  18:42:47   33              ARISTA07T0
10.0.0.47      4  64008       1128       4814         0      0       0  18:42:47   33              ARISTA08T0
10.0.0.49      4  64009       1128       4814         0      0       0  18:42:47   33              ARISTA09T0
10.0.0.51      4  64010       1128       4814         0      0       0  18:42:47   33              ARISTA10T0
10.0.0.53      4  64011       1128       5525         0      0       0  18:42:48   33              ARISTA11T0
10.0.0.55      4  64012       1128       5525         0      0       0  18:42:48   33              ARISTA12T0
10.0.0.57      4  64013       1128       5525         0      0       0  18:42:48   33              ARISTA13T0
10.0.0.59      4  64014       1128       5525         0      0       0  18:42:48   33              ARISTA14T0
10.0.0.61      4  64015       1128       5525         0      0       0  18:42:48   33              ARISTA15T0
10.0.0.63      4  64016       1128       5525         0      0       0  18:42:48   33              ARISTA16T0
10.0.0.65      4  64017       1128       5525         0      0       0  18:42:48   33              ARISTA17T0
10.0.0.67      4  64018       1128       5525         0      0       0  18:42:48   33              ARISTA18T0
10.0.0.69      4  64019       1128       5525         0      0       0  18:42:48   33              ARISTA19T0
10.0.0.71      4  64020       1128       5525         0      0       0  18:42:48   33              ARISTA20T0
25.171.16.3    4  65100          0          0         0      0       0  never      Connect         bgp_monitor

Total number of neighbors 25
admin@sonic:~$

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
@arlakshm arlakshm requested review from abdosi and gechiang March 5, 2021 20:37
@abdosi
Copy link
Contributor

abdosi commented Mar 5, 2021

@arlakshm can you resolve conflcit.

@abdosi
Copy link
Contributor

abdosi commented Mar 5, 2021

@gechiang can you review/approve

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2021

This pull request introduces 1 alert when merging 371a84c into fa07245 - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

arlakshm added 3 commits March 5, 2021 22:23
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2021

This pull request introduces 1 alert and fixes 1 when merging 82a3ee5 into fa07245 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Mar 6, 2021

This pull request fixes 1 alert when merging 5a77a5e into fa07245 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@abdosi abdosi merged commit 9e74075 into sonic-net:201911 Mar 6, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
9e74075 (HEAD -> 201911, origin/201911) [201911][multi asic] show ip bgp summary changes for bgp mon (sonic-net#1483)
fa07245 [CLI][techsupport] Merge 'show techsupport' changes from master (sonic-net#1468)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants