Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route_check: Updates #1565

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

renukamanavalan
Copy link
Contributor

  1. Route check skip routes that are loopback. But if those entries has valid nexthop, they are not ignored from check.

  2. The vrf routes are not handled by route_check.

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…as loopback.

2) The vrf routes are *not* handled.
@renukamanavalan
Copy link
Contributor Author

retest this please

@renukamanavalan
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@renukamanavalan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daall
Copy link
Contributor

daall commented Apr 29, 2021

@renukamanavalan there are merge conflicts w/ 202012, please submit a PR for the 202012 branch.

@renukamanavalan
Copy link
Contributor Author

@daall, this conflict because, there is an update from #1363.
Requested @abdosi to know, if that could be cherry-picked for 202012.

@yxieca
Copy link
Contributor

yxieca commented May 27, 2021

@renukamanavalan we are not taking #1363 to 202012. Please submit separate PR for this change to 202012 branch.

renukamanavalan added a commit to renukamanavalan/sonic-utilities that referenced this pull request May 27, 2021
renukamanavalan added a commit that referenced this pull request May 28, 2021
[cherry-pick #1565]
Route check skip routes that are loopback. But if those entries has valid nexthop, they are not ignored from check.

The vrf routes are not handled by route_check.
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants