-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[route_check] Filter out VNET routes #1612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Samotiy <[email protected]>
This pull request introduces 1 alert when merging 1cad50b into ad801bf - view on LGTM.com new alerts:
|
please add a unit-test |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@volodymyrsamotiy , could you please add a unit-test? |
liat-grozovik
previously approved these changes
Jul 7, 2021
@prsunny on which branches this is required? |
* Add unit test Signed-off-by: Volodymyr Samotiy <[email protected]>
This pull request introduces 1 alert when merging 6ebb5c4 into a99d56d - view on LGTM.com new alerts:
|
prsunny
approved these changes
Aug 20, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 23, 2021
* Filter out VNET routes, Fix errors related to VNET routes printed by route_check script Signed-off-by: Volodymyr Samotiy <[email protected]>
Merged
5 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Filter out VNET routes, Fix errors related to VNET routes printed by route_check script Signed-off-by: Volodymyr Samotiy <[email protected]>
vaibhavhd
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 26, 2021
Update sonic-utilities submodule to latest in 202012 branch: [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled sonic-net/sonic-utilities#1678 [route_check] Filter out VNET routes sonic-net/sonic-utilities#1612 [Show] Update the subcommands of Kdump. sonic-net/sonic-utilities#1682 Add mock support for swsscommon classes sonic-net/sonic-utilities#1780 [acl_loader]: add iptype match to the rules for dataplane acl sonic-net/sonic-utilities@205aff8 [202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json before fast-reboot sonic-net/sonic-utilities#1774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy [email protected]
What I did
Fixed errors related to VNET routes printed by
route_check
script.How I did it
Filtered out VNET routes for the list of routes that are taken into account by
route_check
script.How to verify it
route_check
script on the switchPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)