Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console][show] Force refresh all lines status during show line #1641

Merged
merged 2 commits into from
May 27, 2021
Merged

[console][show] Force refresh all lines status during show line #1641

merged 2 commits into from
May 27, 2021

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented May 26, 2021 •
edited
Loading

What I did

Address issue #1639

How I did it

Force refresh each lines status during show line

How to verify it

Add unit tests:
Cases:

tests/console_test.py::TestConfigConsoleCommands::test_enable_console_switch PASSED [ 19%]
tests/console_test.py::TestConfigConsoleCommands::test_disable_console_switch PASSED [ 19%]
tests/console_test.py::TestConfigConsoleCommands::test_console_add_exists PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_console_add_no_baud PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_console_add_name_conflict PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_console_add_success PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_console_del_non_exists PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_console_del_success PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_remote_device_name_non_exists PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_remote_device_name_conflict PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_remote_device_name_existing_and_same PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_remote_device_name_reset PASSED [ 20%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_remote_device_name_success PASSED [ 21%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_baud_no_change PASSED [ 21%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_baud_non_exists PASSED [ 21%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_baud_success PASSED [ 21%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_flow_control_no_change PASSED [ 21%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_flow_control_non_exists PASSED [ 21%]
tests/console_test.py::TestConfigConsoleCommands::test_update_console_flow_control_success PASSED [ 21%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_all_configured_only_empty PASSED [ 21%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_all_configured_only_nonempty PASSED [ 21%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_all_with_ttys PASSED [ 21%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_line_success PASSED [ 21%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_line_not_found PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_line_by_device_success PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_provider_get_line_by_device_not_found PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_refresh_without_session PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_refresh_without_session_idle PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_refresh_with_session PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_refresh_with_session_line_mismatch PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_refresh_with_session_process_ended PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_connect_state_busy PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_connect_invalid_config PASSED [ 22%]
tests/console_test.py::TestConsutilLib::test_console_port_info_connect_device_busy PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_console_port_info_connect_connection_fail PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_console_port_info_connect_success PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_console_port_info_clear_session_line_not_busy PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_console_port_info_clear_session_with_state_db PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_console_port_info_clear_session_with_existing_session PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_init_device_prefix_plugin_nonexists PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_init_device_prefix_plugin PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_list_console_ttys PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_list_console_ttys_device_not_exists PASSED [ 23%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_list_active_console_processes PASSED [ 24%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_get_active_console_process_info_exists PASSED [ 24%]
tests/console_test.py::TestConsutilLib::test_sys_info_provider_get_active_console_process_info_nonexists PASSED [ 24%]
tests/console_test.py::TestConsutil::test_consutil_feature_disabled_null_config PASSED [ 24%]
tests/console_test.py::TestConsutil::test_consutil_feature_disabled_config PASSED [ 24%]
tests/console_test.py::TestConsutil::test_consutil_feature_enabled PASSED [ 24%]
tests/console_test.py::TestConsutilShow::test_show PASSED                [ 24%]
tests/console_test.py::TestConsutilShow::test_show_stale_idle_to_busy PASSED [ 24%]
tests/console_test.py::TestConsutilShow::test_show_stale_busy_to_idle PASSED [ 24%]
tests/console_test.py::TestConsutilConnect::test_connect_target_nonexists PASSED [ 24%]
tests/console_test.py::TestConsutilConnect::test_connect_line_busy PASSED [ 25%]
tests/console_test.py::TestConsutilConnect::test_connect_no_baud PASSED  [ 25%]
tests/console_test.py::TestConsutilConnect::test_connect_picocom_err PASSED [ 25%]
tests/console_test.py::TestConsutilConnect::test_connect_success PASSED  [ 25%]
tests/console_test.py::TestConsutilClear::test_clear_without_root PASSED [ 25%]
tests/console_test.py::TestConsutilClear::test_clear_line_not_found PASSED [ 25%]
tests/console_test.py::TestConsutilClear::test_clear_idle PASSED         [ 25%]
tests/console_test.py::TestConsutilClear::test_clear_success PASSED      [ 25%]

Coverage

consutil/lib.py                                 232      7     58      2    97%
consutil/main.py                                 75      3     16      1    96%

Install the new package in DUT and test related functions as well.

Previous command output (if the output of a command-line utility has changed)

No change.

New command output (if the output of a command-line utility has changed)

No change.

@Blueve Blueve linked an issue May 26, 2021 that may be closed by this pull request
[console] show line result is stale if console session ended unexpected #1639
Closed
@Blueve Blueve marked this pull request as ready for review May 26, 2021 13:51
@Blueve Blueve merged commit 18bed46 into sonic-net:master May 27, 2021
@Blueve Blueve deleted the dev/jika/showline branch May 27, 2021 00:24
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
@Blueve @gitsabari
[console][show] Force refresh all lines status during show line (soni…
c0d8ade 
…c-net#1641)

* [console][show] Force refresh all lines status during show line
* Fix UTs

Signed-off-by: Jing Kan [email protected]
qiluo-msft pushed a commit that referenced this pull request Aug 3, 2021
@Blueve @qiluo-msft
[console][show] Force refresh all lines status during show line (#1641)
d68ac1c 
* [console][show] Force refresh all lines status during show line
* Fix UTs

Signed-off-by: Jing Kan [email protected]
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-utilities that referenced this pull request Aug 10, 2021
@Blueve @raphaelt-nvidia
[console][show] Force refresh all lines status during show line (soni…
16bf6b2 
…c-net#1641)

* [console][show] Force refresh all lines status during show line
* Fix UTs

Signed-off-by: Jing Kan [email protected]
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
@yxieca
[202012][utilities] advance sonic-utilities submodule head (#8355)
a21fdeb 
To include following changes:

* d84a8cc 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (sonic-net#1744) (HEAD -> 202012, github/202012) [Ying Xie]
* e900bc5 2021-08-04 | Add script null_route_helper (sonic-net#1718) [bingwang-ms]
* 85f14e1 2021-08-02 | disk_check updates: (sonic-net#1736) [Renuka Manavalan]
* d68ac1c 2021-05-27 | [console][show] Force refresh all lines status during show line (sonic-net#1641) [Blueve]
* a0e417f 2021-04-25 | [console] Display success message after line cleared (sonic-net#1579) [Blueve]
* 0c6bb27 2021-04-07 | [console] Include Flow Control status in show line result (sonic-net#1549) [Blueve]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

Assignees
No one assigned
Labels
Bug Enhancement Included in 202012 Branch Request for 202012 Branch show
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[console] show line result is stale if console session ended unexpected
3 participants
@Blueve @yxieca @qiluo-msft