Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonic-installer failure due to missing import #2090

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

pavannaregundi
Copy link
Contributor

Signed-off-by: Pavan Naregundi [email protected]

What I did

Fixes #2089.
Sonic-installer failure was seen due to missing import in uboot.py.

How I did it

Fix is just adding missing import.

How to verify it

Fix has been tested for successful sonic installation from sonic-installer

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Change-Id: I44bea3d2f89413d2d0dacfb1b6b7d19b15e52a09
Signed-off-by: Pavan Naregundi <[email protected]>
@qiluo-msft qiluo-msft requested a review from wen587 March 10, 2022 00:41
Copy link
Contributor

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachinv-msft
Copy link

@qiluo-msft could you please merge this PR?

@yxieca yxieca merged commit 6289987 into sonic-net:master Mar 10, 2022
judyjoseph pushed a commit that referenced this pull request Mar 20, 2022
What I did
Fixes #2089.
Sonic-installer failure was seen due to missing import in uboot.py.

How I did it
Fix is just adding missing import.

How to verify it
Fix has been tested for successful sonic installation from sonic-installer

Change-Id: I44bea3d2f89413d2d0dacfb1b6b7d19b15e52a09
Signed-off-by: Pavan Naregundi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sonic-installer install fails in armhf
6 participants