[acl-loader] Support for ACL table type L3V4V6 #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bingwang-ms can you please take a look at the acl-loader changes. It is related to the HLD and swss code that you helped review. |
|
@prsunny @qiluo-msft Please review and merge this before 202305 fork. It has been open for 3 weeks now. |
bingwang-ms
reviewed
May 8, 2023
bingwang-ms
reviewed
May 8, 2023
bingwang-ms
reviewed
May 8, 2023
rck-innovium
force-pushed
the
marvell_l3_acl
branch
from
a2418a7 to
0db9397
Compare
|
@bingwang-ms Thanks for the review. I have addressed the review comments and updated the pull request. |
bingwang-ms
previously approved these changes
May 9, 2023
|
Thanks for the improvement. LGTM now. |
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
rck-innovium
force-pushed
the
marvell_l3_acl
branch
from
0db9397 to
949301d
Compare
@prsunny @qiluo-msft Can you please approve and merge |
bingwang-ms
approved these changes
May 11, 2023
@prsunny @qiluo-msft Can you please help merge this for 202305 release. This PR has been approved 3 weeks ago. |
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a new ACL table type called L3V4V6.
This table supports both v4 and v6 Match types.
Added unit tests for this new ACL table type.
HLD: sonic-net/SONiC#1267
Signed-off-by: Ravi(Marvell) [email protected]
What I did
Support a new ACL table type called L3V4V6.
How I did it
How to verify it