-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YANG validation for config reload if file is given #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xincunli-sonic
previously approved these changes
Oct 16, 2024
ganglyu
reviewed
Oct 17, 2024
ganglyu
approved these changes
Oct 17, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Oct 21, 2024
What I did Add constraint for YANG when config reload, which is already enabled in load_minigraph How I did it Check YANG vaidation for the config How to verify it Unit test
Cherry-pick PR to 202405: #3581 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 21, 2024
What I did Add constraint for YANG when config reload, which is already enabled in load_minigraph How I did it Check YANG vaidation for the config How to verify it Unit test
oleksandrivantsiv
added a commit
to oleksandrivantsiv/sonic-utilities
that referenced
this pull request
Nov 9, 2024
…-net#3576)" This reverts commit 89bb87a.
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Dec 5, 2024
…-net#3576)" This reverts commit 89bb87a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO:29948924
What I did
Add constraint for YANG when config reload, which is already enabled in load_minigraph
How I did it
Check YANG vaidation for the config
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)