Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show][config] Add CLI support for configurable drop monitor feature #3756

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arista-hpandya
Copy link
Contributor

@arista-hpandya arista-hpandya commented Feb 7, 2025

This PR enables users to proactively monitor and identify persistent packet drops in their SONiC environment, improving network stability and troubleshooting capabilities.

Fixes #3757

What I did

  • Implements commands to configure persistent drop monitor thresholds.
  • Adds support for setting monitoring window size, drop count threshold, and incident count threshold.
  • Includes show dropcounters monitor command to display current configuration.
  • Provides config dropcounters monitor command to enable/disable and configure the monitor.
  • Adds unit tests to cover the new CLI functionality.
Key Features:
  • Configurable monitoring window: Users can specify the time window (in seconds) for detecting persistent drops.
  • Adjustable thresholds: Users can set the minimum number of drops required to trigger an incident and the minimum number of incidents to trigger a syslog entry.
  • Global configuration: The configured parameters apply to all drop counters on the device.

How I did it

  • Modified the existing dropconfig script

How to verify it

  • Added unit tests to cover the new CLI functionality.
  • Manual testing performed on a SONiC device to verify configuration and syslog output.

Previous command output (if the output of a command-line utility has changed)

NA

New command output (if the output of a command-line utility has changed)

image

Documentation

Details are discussed in the HLD: sonic-net/SONiC#1912

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

*   Implements commands to configure persistent drop monitor thresholds.
*   Adds support for setting monitoring window size, drop count threshold, and incident count threshold.
*   Includes `show dropcounters monitor` command to display current configuration.
*   Provides `config dropcounters monitor` command to enable/disable and configure the monitor.
*   Adds unit tests to cover the new CLI functionality.
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add CLI support for configuring persistent drop monitor
2 participants