Fixes bug for PFCWD feature parameters #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 1, 2020 21:52
|
@volodymyrsamotiy @liat-grozovik |
liat-grozovik
previously approved these changes
Mar 17, 2020
lguohan
reviewed
Mar 22, 2020
lguohan
reviewed
Mar 22, 2020
neethajohn
suggested changes
Mar 25, 2020
neethajohn
previously approved these changes
Mar 30, 2020
neethajohn
approved these changes
Apr 6, 2020
liat-grozovik
approved these changes
Apr 7, 2020
lguohan
approved these changes
Apr 7, 2020
abdosi
pushed a commit
that referenced
this pull request
Jun 16, 2020
What I did The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'. The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1. How I did it Checking the config DB for interfaces PFCWD values. How to verify it Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces. Previous command output (if the output of a command-line utility has changed) No Output. New command output (if the output of a command-line utility has changed) unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table
abdosi
added a commit
to abdosi/sonic-mgmt
that referenced
this pull request
Jun 22, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time. So make sure in testscript before setting poll interval stop pfc wd if enable by default because default detection/restoration time can be < poll time interval making script failure.
abdosi
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jun 23, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time. So make sure in testscript before setting poll interval stop pfc wd if enable by default because default detection/restoration time can be < poll time interval making script failure.
yxieca
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jun 24, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time. So make sure in testscript before setting poll interval stop pfc wd if enable by default because default detection/restoration time can be < poll time interval making script failure.
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
What I did The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'. The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1. How I did it Checking the config DB for interfaces PFCWD values. How to verify it Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces. Previous command output (if the output of a command-line utility has changed) No Output. New command output (if the output of a command-line utility has changed) unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911][thermal control] Backport changes from master branch (sonic-net#929) [201911][config] Support abbreviation (sonic-net#933) Add 'hw-management-generate-dump.sh' to 'show techsupport' command (sonic-net#934) [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942) Fixes bug for PFCWD feature parameters (sonic-net#838) Fixed fast-reboot for BFN platform (sonic-net#871) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) [warm-reboot]: added pre-check for ISSU file (sonic-net#915) [config] Don't attempt to restart disabled services (sonic-net#944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'.
The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1.
How I did it
Checking the config DB for interfaces PFCWD values.
How to verify it
Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces.
Previous command output (if the output of a command-line utility has changed)
No Output.
New command output (if the output of a command-line utility has changed)
unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table