-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved route_check tool and adopt to 20191130 image. #898
Conversation
This pull request fixes 1 alert when merging 61a7a7e into 3471926 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 172d9df into 3471926 - view on LGTM.com fixed alerts:
|
…0' as local routes 2) Ensure to read route entry w/o prefix, if not present with prefix
This pull request fixes 1 alert when merging 8267876 into e747456 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lgtm says, I fixed an issue that was there in previous code. |
is this needed for 201811 image? does not seem to match the title of this pr |
201811 branch is only taking bug fixes at this point. |
* Changes: 1) Add syslog support. 2) Enable forever periodic scan 3) Skip link local addresses 4) Skip eth0 routes 3) Adopt to 20191130 changes 3.1) APPl-DB INTF_TABLE may not have IP address 3.2) nexthop is never empty * No logical code change. A small name change. * 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes 2) Ensure to read route entry w/o prefix, if not present with prefix
* Changes: 1) Add syslog support. 2) Enable forever periodic scan 3) Skip link local addresses 4) Skip eth0 routes 3) Adopt to 20191130 changes 3.1) APPl-DB INTF_TABLE may not have IP address 3.2) nexthop is never empty * No logical code change. A small name change. * 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes 2) Ensure to read route entry w/o prefix, if not present with prefix
[Vnet] Fix NameError for 'swsssdk' and align output (sonic-net#902) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) Improved route_check tool and adopt to 20191130 image. (sonic-net#898)
3.1) APPl-DB INTF_TABLE may not have IP address
3.2) nexthop is never empty
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)