[Megrez] supported #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangz-ai
reviewed
Dec 27, 2024
There was a problem hiding this comment.
export_onnx.py
- ID_EOS = [120005, 120000, 120025]最好不要定死，一般会有tokenizer.im_eos_id这种
- 建议最好还是不要支持lmhead+top1这种贪婪采样，因为小模型，3B还好1.8B这种可能容易出现重复token的情况。建议同时支持贪婪和惩罚
chat.cpp
NUM_LAYERS最好也不要写死，直接写成32，不然以后不太好改，可以读模型config,json
或者放在pipeline.py里面最为一个--num_layers的参数
其他都写得蛮好的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.