Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: remove redundant message, fix confirmation message for evm part #660

Merged
merged 4 commits into from
Apr 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lang/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Hotovo",
"waitingForConfirmation": "Čeká se na potvrzení..."
},
"wait30Block": "Vyčkejte prosím 30 potvrzení bloku",
"viewInEtherscan": "Zobrazit v Etherscanu",
"networkTitle": "{network} transakce",
"transactionHash": "Hash transakce",
Expand Down
1 change: 0 additions & 1 deletion src/lang/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Erfolgreich",
"waitingForConfirmation": "Warten auf Bestätigung..."
},
"wait30Block": "Bitte, warte 30 Blockbestätigungen",
"viewInEtherscan": "Auf Etherscan anzeigen",
"networkTitle": "{network} Transaktion",
"transactionHash": "Transaktions-ID",
Expand Down
1 change: 0 additions & 1 deletion src/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Complete",
"waitingForConfirmation": "Waiting for confirmation..."
},
"wait30Block": "Please wait 30 block confirmations",
"viewInEtherscan": "View in Etherscan",
"networkTitle": "{network} transaction",
"transactionHash": "Transaction hash",
Expand Down
1 change: 0 additions & 1 deletion src/lang/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Completo",
"waitingForConfirmation": "Esperando confirmación..."
},
"wait30Block": "Espere 30 confirmaciones de bloque",
"viewInEtherscan": "Ver en Etherscan",
"networkTitle": "Transacción de {network}",
"transactionHash": "Hash de la transacción",
Expand Down
1 change: 0 additions & 1 deletion src/lang/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Compléter",
"waitingForConfirmation": "En attente de confirmation..."
},
"wait30Block": "Veuillez attendre 30 confirmations de block",
"viewInEtherscan": "Afficher dans Etherscan",
"networkTitle": "transaction {network}",
"transactionHash": "Hash de transaction",
Expand Down
1 change: 0 additions & 1 deletion src/lang/hy.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Վերջացված է",
"waitingForConfirmation": "Հաստատման սպասում ..."
},
"wait30Block": "Խնդրում ենք սպասել 30 բլոկի հաստատատման",
"viewInEtherscan": "Դիտել Etherscan- ում",
"networkTitle": "{network} գործարք",
"transactionHash": "Գործարքի հաշ(կոդ)",
Expand Down
1 change: 0 additions & 1 deletion src/lang/id.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Berhasil",
"waitingForConfirmation": "Menunggu konfirmasi..."
},
"wait30Block": "Silakan tunggu 30 blok terkonfirmasi",
"viewInEtherscan": "Lihat di Etherscan",
"networkTitle": "Transaksi {network}",
"transactionHash": "Hash transaksi",
Expand Down
1 change: 0 additions & 1 deletion src/lang/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Completata",
"waitingForConfirmation": "In attesa di conferma..."
},
"wait30Block": "Si prega di attendere 30 blocchi di conferma",
"viewInEtherscan": "Visualizza in Etherscan",
"networkTitle": "transazione {network}",
"transactionHash": "Hash della transazione",
Expand Down
1 change: 0 additions & 1 deletion src/lang/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ export default {
done: 'Complete',
waitingForConfirmation: 'Waiting for confirmation...',
},
wait30Block: 'Please wait 30 block confirmations',
blocksLeft: '{count} blocks left...',
viewInEtherscan: 'View in Etherscan',
networkTitle: '{network} transaction',
Expand Down
1 change: 0 additions & 1 deletion src/lang/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Compleet",
"waitingForConfirmation": "Wachten op bevestiging..."
},
"wait30Block": "Gelieve 30 blokbevestigingen te wachten",
"viewInEtherscan": "Bekijk in Etherscan",
"networkTitle": "{Netwerk} transactie",
"transactionHash": "Transactie hash",
Expand Down
1 change: 0 additions & 1 deletion src/lang/no.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Ferdig",
"waitingForConfirmation": "Venter på bekreftelse..."
},
"wait30Block": "Vent på 30 blokkbekreftelser",
"viewInEtherscan": "Vis i Etherscan",
"networkTitle": "{network} transaksjon",
"transactionHash": "Transaksjon hash",
Expand Down
1 change: 0 additions & 1 deletion src/lang/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Ukończono",
"waitingForConfirmation": "Oczekiwanie na potwierdzenie..."
},
"wait30Block": "Proszę poczekać, aż 30 bloków zostanie potwierdzonych.",
"viewInEtherscan": "Pokaż w Etherscanie",
"networkTitle": "transakcji sieci {network}",
"transactionHash": "Skrót transakcji",
Expand Down
1 change: 0 additions & 1 deletion src/lang/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Выполнено",
"waitingForConfirmation": "Ожидание подтверждения..."
},
"wait30Block": "Пожалуйста, дождитесь 30 подтверждений блока",
"viewInEtherscan": "Посмотреть в Etherscan",
"networkTitle": "{network} транзакция",
"transactionHash": "Хеш транзакции",
Expand Down
1 change: 0 additions & 1 deletion src/lang/yo.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
"done": "Pari",
"waitingForConfirmation": "Nduro fun idaniloju ..."
},
"wait30Block": "Jọwọ duro awọn ijẹrisi idiwọ ogbon",
"viewInEtherscan": "Wo ni Etherscan",
"networkTitle": "idunadura {network}",
"transactionHash": "Ami Iṣowo",
Expand Down
15 changes: 7 additions & 8 deletions src/views/BridgeTransaction.vue
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,9 @@ export default class BridgeTransaction extends Mixins(mixins.FormattedAmountMixi

get statusFrom(): string {
if (this.isTransactionFromPending) {
if (!this.isSoraToEvm && !this.transactionFromHash) {
return this.t('bridgeTransaction.statuses.waitingForConfirmation');
}
return this.t('bridgeTransaction.statuses.pending') + '...';
}
if (this.isTransactionFromFailed) {
Expand All @@ -526,23 +529,19 @@ export default class BridgeTransaction extends Mixins(mixins.FormattedAmountMixi
}

get statusTo(): string {
if (!this.isTransactionFromCompleted) {
return this.t('bridgeTransaction.statuses.waiting') + '...';
}
if (this.isTransactionToPending) {
const message = this.t('bridgeTransaction.statuses.pending') + '...';
if (this.isSoraToEvm) {
return message;
if (this.isSoraToEvm && !this.transactionToHash) {
return this.t('bridgeTransaction.statuses.waitingForConfirmation');
}
return `${message} (${this.t('bridgeTransaction.wait30Block')})`;
return this.t('bridgeTransaction.statuses.pending') + '...';
}
if (this.isTransactionToFailed) {
return this.t('bridgeTransaction.statuses.failed');
}
if (this.isTransactionToCompleted) {
return this.t('bridgeTransaction.statuses.done');
}
return this.t('bridgeTransaction.statuses.waitingForConfirmation');
return this.t('bridgeTransaction.statuses.waiting') + '...';
}

get transactionEvmAddress(): string {
Expand Down