Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Offline Guide] fixed one payload/meta inconsistency #38

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

elf-pavlik
Copy link

copy of redux-offline#123

I wasn't sure which one, the action or the reducer, needed a fix so I just followed the consistent way from following section A pessimist is never disappointed - _COMMIT and _FALLBACK use meta not payload.

@wacii
Copy link
Collaborator

wacii commented Sep 26, 2017

You certainly picked the right one as the payload gets overridden in commit and rollback actions. Thanks for the PR.

@wacii wacii merged commit 854a5b2 into sorodrigo:develop Sep 26, 2017
@elf-pavlik elf-pavlik deleted the patch-1 branch November 6, 2017 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants