Fix failing test #51
Merged
Fix failing test #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a test that failed sporadically. It should have been failing all the time, not because the underlying feature was broken, but because I forgot to add necessary meta information to an offline action being used in the test.
Both the failing and sporadically parts have been fixed. I took the opportunity to make some other improvements. Specifically not reusing the default state in case someone mutated it and separating noop from the default reducer, which had been merged for some reason.
I will leave this up for a few days in case anyone wants to take a look before I merge it.