Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pydantic to v2 and redis-om to v0.3. #138

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Update Pydantic to v2 and redis-om to v0.3. #138

merged 11 commits into from
Oct 2, 2024

Conversation

ProKil
Copy link
Member

@ProKil ProKil commented Jul 16, 2024

Closes #72

📑 Description

Update Pydantic to v2 and redis-om to v0.3. This PR is meant to be for v0.2 of sotopia, so please merge this after tagging v0.1.

Working, but still WIP: there are a few warnings to resolve

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

@ProKil ProKil added the don't merge now Please don't merge or close it right now. label Jul 16, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 84.04255% with 15 lines in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (785669c) to head (861210c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sotopia/generation_utils/generate.py 27.27% 8 Missing ⚠️
sotopia/envs/evaluators.py 80.00% 3 Missing ⚠️
sotopia/agents/redis_agent.py 0.00% 2 Missing ⚠️
sotopia/database/persistent_profile.py 71.42% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   69.42%   69.39%   -0.04%     
==========================================
  Files          56       56              
  Lines        2973     2973              
==========================================
- Hits         2064     2063       -1     
- Misses        909      910       +1     
Files with missing lines Coverage Δ
sotopia/database/annotators.py 100.00% <100.00%> (ø)
sotopia/database/logs.py 95.74% <100.00%> (ø)
sotopia/database/serialization.py 97.86% <100.00%> (ø)
sotopia/database/session_transaction.py 77.27% <100.00%> (ø)
sotopia/renderers/base.py 78.94% <100.00%> (ø)
sotopia/agents/redis_agent.py 21.91% <0.00%> (ø)
sotopia/database/persistent_profile.py 90.56% <71.42%> (ø)
sotopia/envs/evaluators.py 89.50% <80.00%> (ø)
sotopia/generation_utils/generate.py 56.00% <27.27%> (ø)

... and 1 file with indirect coverage changes

@ProKil ProKil marked this pull request as ready for review August 22, 2024 04:05
@ProKil ProKil changed the title Draft PR for v0.2 Update Pydantic to v2 and redis-om to v0.3. Aug 22, 2024
@ProKil ProKil added this to the 0.2.0 Release milestone Aug 22, 2024
@ProKil ProKil requested review from XuhuiZhou and bugsz August 22, 2024 21:41
@ProKil ProKil removed the don't merge now Please don't merge or close it right now. label Aug 24, 2024
Copy link
Member

@XuhuiZhou XuhuiZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is good, but should we also update the doc at the same time?

sotopia/database/serialization.py Show resolved Hide resolved
sotopia/generation_utils/generate.py Show resolved Hide resolved
@ProKil
Copy link
Member Author

ProKil commented Oct 2, 2024

Nothing from the usage perspective has changed. This can be verified by the fact that it passed all of the test cases for sotopia v0.1

@ProKil ProKil merged commit 2a51167 into main Oct 2, 2024
8 checks passed
@ProKil ProKil deleted the v0.2 branch October 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Pydantic V2 + RedisOm Python V0.3
3 participants