Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Constraint generator #123

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

WIP: Constraint generator #123

wants to merge 2 commits into from

Conversation

soullivaneuh
Copy link
Owner

@soullivaneuh soullivaneuh commented Jan 12, 2017

Closes #122

  • Constraint class generation
  • Test generation
  • Move to Twig v2.
  • Translation basic generation (for each translation files, even future one. Default key will be used).
  • Re-generate translation file for existing constraints (another commit). Check for possible BC breaks.

For translation, try with XliffFileLoader/Dumper.

After that, generate validators for another PR.

@soullivaneuh soullivaneuh self-assigned this Jan 12, 2017
@soullivaneuh soullivaneuh changed the title Constraint generator WIP: Constraint generator Jan 12, 2017
@soullivaneuh soullivaneuh force-pushed the generator branch 3 times, most recently from d513fc4 to 4b1eac5 Compare January 12, 2017 17:14
@sstok
Copy link

sstok commented Jan 12, 2017

FYI:

  • You don't have to remove the entire vendor directory just the affected package (and Composer will install the source for only the missing packages 👍 )
  • Usually the term "directory" is used rather then "folder" (which is Windows specific).

@soullivaneuh
Copy link
Owner Author

@sstok Thanks for your participation! :-)

I think I'll make the command removing the directory itself. 😉

@soullivaneuh
Copy link
Owner Author

I think I'll make the command removing the directory itself.

Well, I'll not. It will be safer to have the version from composer.

@soullivaneuh soullivaneuh force-pushed the generator branch 8 times, most recently from 8cd36db to 12fd7d3 Compare January 13, 2017 17:14
Repository owner deleted a comment from stickler-ci Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants