Major Refactoring #952
Draft
Major Refactoring #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from actual game data banks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to start as creating an MSBBank, following on from other structuredbank work.
However the rendering framework and msbeditor seemed to be a little too closely tied, and the foundation of the msbeditor is to create a parallel to msb in the form of map, defeating any use of an msb bank, so in the work splitting apart the msbeditor, a lot of other cleanup got done instead.
I'm opening the PR to see if anyone has any strong opinions on this, or if they want to offer themselves to write msbeditornew, since the current one is such a jumble