This repository has been archived by the owner on Dec 10, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Passing custom class as component #36
Comments
Hmm interesting, no it wasn't intended. I did not realize you could pass a custom component like that. Totally makes sense though. If you'd like to do a PR, I can review it and bring it in if all looks good. Should be just a PropType update correct? |
Yes should be just PropType update, however not sure if just React.PropTypes.element element will work or need a custom validator with checking for React.isValidElement(). |
asvetliakov
added a commit
to asvetliakov/react-motion-ui-pack
that referenced
this issue
Feb 25, 2016
…op. Fixes souporserious#36 Uses function from react-prop-types lib
asvetliakov
added a commit
to asvetliakov/react-motion-ui-pack
that referenced
this issue
Mar 1, 2016
…op. Fixes souporserious#36 Uses function from react-prop-types lib
souporserious
added a commit
that referenced
this issue
Mar 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Has passing only html tags as strings and {false} to component prop of Transition been intended?
I'm trying to do something like:
This works but gives me warning about incorrect prop types
The text was updated successfully, but these errors were encountered: