Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware): export client and user authentication middlewares #257

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

rashisf
Copy link
Contributor

@rashisf rashisf commented Jan 7, 2025

Description

resolves #256
Exported ClientAuthenticationMiddlewareProvider and UserAuthenticationMiddlewareProvider in index.ts file.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • use of Client authentication middleware in custom sequence
  • use of User authentication middleware in custom sequence

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@rashisf rashisf requested a review from yeshamavani January 7, 2025 14:00
@yeshamavani
Copy link
Contributor

Can you update the readme file as well
since now user can define custom chains as well

@rashisf rashisf force-pushed the 256-export-middlewares branch from 160724b to 23ae356 Compare January 8, 2025 07:07
@rashisf rashisf force-pushed the 256-export-middlewares branch from 23ae356 to 8f59785 Compare January 8, 2025 07:11
Copy link

sonarqubecloud bot commented Jan 8, 2025

@rashisf
Copy link
Contributor Author

rashisf commented Jan 8, 2025

Can you update the readme file as well since now user can define custom chains as well

Updated the docs.

@yeshamavani yeshamavani merged commit 4f8e849 into sourcefuse:master Jan 9, 2025
5 checks passed
@yeshamavani
Copy link
Contributor

🎉 This PR is included in version 12.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export client-authentication and user-authentication middlewares
2 participants