Auth: get notified on auth change #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
commented
Aug 14, 2024
| if (key == "cody.activated") | ||
| { | ||
| var isAuthenticated = value == "true"; | ||
| DebugLog(isAuthenticated.ToString(), "User is authenticated"); |
There was a problem hiding this comment.
@PiotrKarczmarz @tomaszgolebiowski here is where we can get notified when user auth status has changed so we don't need to poll AuthStatus constantly.
tomaszgolebiowski
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-3170/disable-right-click-context-menu-for-the-webview-if-the-extension-is
Also added a form for users to login in the webview, but currently the token is not stored anyway and can only be used during the current session. We will need to work on a follow-up to store the provided token to the extension secret storage.
vs_auth.mp4
To try the sign in screen, just remove your token from the env var to trigger the Auth view