fix: remove trailing spaces from extracted query #6432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
approved these changes
Dec 22, 2024
thenamankumar
approved these changes
Dec 23, 2024
abeatrix
pushed a commit
that referenced
this pull request
Dec 23, 2024
…query (#6440) When we remove the mentions, for some reason we're trimming spaces from the start, but not the end. This means our exact match heuristics won't work as well for these situations because there's a rogue space at the end of the query. This just fixes the logic to trim spaces from both the start and end ## Test plan This query used to give less relevant results because we kept the trailing space:  <br> Backport 78da6bb from #6432 Co-authored-by: Camden Cheek <[email protected]>
abeatrix
pushed a commit
that referenced
this pull request
Dec 23, 2024
…#6446) When we remove the mentions, for some reason we're trimming spaces from the start, but not the end. This means our exact match heuristics won't work as well for these situations because there's a rogue space at the end of the query. This just fixes the logic to trim spaces from both the start and end ## Test plan This query used to give less relevant results because we kept the trailing space:  <br> Backport 78da6bb from #6432 Co-authored-by: Camden Cheek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we remove the mentions, for some reason we're trimming spaces from the start, but not the end. This means our exact match heuristics won't work as well for these situations because there's a rogue space at the end of the query.
This just fixes the logic to trim spaces from both the start and end
Test plan
This query used to give less relevant results because we kept the trailing space:
