chore(ES): update CTAs and eligibility logic #6803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarquespt
approved these changes
Jan 27, 2025
eseliger
approved these changes
Jan 27, 2025
vscode/webviews/CodyPanel.tsx
Outdated
| @@ -80,8 +81,9 @@ export const CodyPanel: FunctionComponent<CodyPanelProps> = ({ | |||
| const api = useExtensionAPI() | |||
| const { value: chatModels } = useObservable(useMemo(() => api.chatModels(), [api.chatModels])) | |||
| const isPromptsV2Enabled = useFeatureFlag(FeatureFlag.CodyPromptsV2) | |||
| const isTeamsUpgradeCtaEnabled = useFeatureFlag(FeatureFlag.SourcegraphTeamsUpgradeCTA) | |||
|
|
|||
| // Teams upgrade eligibility should be that the flag is set, is on dotcom and only has one account. This prevents enterprise customers that are logged into multiple endpoints from seeing the CTA | |||
There was a problem hiding this comment.
can we name this workspaces and not teams? the name is outdated 😬
This was referenced Jan 27, 2025
thenamankumar
pushed a commit
that referenced
this pull request
Jan 28, 2025
…6826) Updated CTA links and eligibility logic, see Loom and [CODY-4659](https://linear.app/sourcegraph/issue/CODY-4659/profile-menu-ctas) for full details https://www.loom.com/share/2222084d04a14e1ba080b06c92207a19?sid=67bc08e2-e284-4616-92e4-1f087145a480 Closes https://linear.app/sourcegraph/issue/CORE-535/cody-clients-migrate-ctas-to-live-links. ## Test plan 1. Tested CTA eligibility on dotcom, and enterprise instances 2. Checked dismiss notifications did not break webview 3. Checked links and confirmed that they matched with designs 4. Switched across multiple accounts and everything still worked <br> Backport 7da7444 from #6803 Co-authored-by: Kalan <[email protected]>
thenamankumar
pushed a commit
that referenced
this pull request
Jan 28, 2025
#6825) Updated CTA links and eligibility logic, see Loom and [CODY-4659](https://linear.app/sourcegraph/issue/CODY-4659/profile-menu-ctas) for full details https://www.loom.com/share/2222084d04a14e1ba080b06c92207a19?sid=67bc08e2-e284-4616-92e4-1f087145a480 Closes https://linear.app/sourcegraph/issue/CORE-535/cody-clients-migrate-ctas-to-live-links. ## Test plan 1. Tested CTA eligibility on dotcom, and enterprise instances 2. Checked dismiss notifications did not break webview 3. Checked links and confirmed that they matched with designs 4. Switched across multiple accounts and everything still worked <br> Backport 7da7444 from #6803 Co-authored-by: Kalan <[email protected]>
ichim-david
reviewed
Jan 28, 2025
| <p className="tw-text-muted-foreground tw-mb-2 tw-text-[12px]"> | ||
| Get search, AI chat, autocompletes and inline edits for your entire team to find, | ||
| understand and fix code across all of your codebases. | ||
| Get your own workspace with AI-powered chat, prompt sharing and codebase serach. Automate |
There was a problem hiding this comment.
@kalanchan you have a typo on the spelling of search:
"Get your own workspace with AI-powered chat, prompt sharing and codebase serach. Automate
Comment"
I think you should fix this before this pull request is backported to other branches.
ichim-david
reviewed
Jan 28, 2025
| unlock Code Search, AI chat, autocompletes, inline edits | ||
| and more for your team. | ||
| Get your own workspace with AI-powered chat, prompt | ||
| sharing and codebase serach. Automate tasks and |
There was a problem hiding this comment.
@kalanchan same, you've misspelled search
kalanchan
added a commit
that referenced
this pull request
Jan 28, 2025
Fixes typo introduced in #6803 ## Test plan Ran locally, confirmed text change has been applied to dotcom users only <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. -->
This was referenced Jan 28, 2025
umpox
pushed a commit
that referenced
this pull request
Jan 29, 2025
Fixes typo introduced in #6803 ## Test plan Ran locally, confirmed text change has been applied to dotcom users only <br> Backport 1e7df48 from #6856 Co-authored-by: Kalan <[email protected]>
umpox
pushed a commit
that referenced
this pull request
Jan 29, 2025
Fixes typo introduced in #6803 ## Test plan Ran locally, confirmed text change has been applied to dotcom users only <br> Backport 1e7df48 from #6856 Co-authored-by: Kalan <[email protected]>
taiyab
pushed a commit
that referenced
this pull request
Feb 3, 2025
Updated CTA links and eligibility logic, see Loom and [CODY-4659](https://linear.app/sourcegraph/issue/CODY-4659/profile-menu-ctas) for full details https://www.loom.com/share/2222084d04a14e1ba080b06c92207a19?sid=67bc08e2-e284-4616-92e4-1f087145a480 Closes https://linear.app/sourcegraph/issue/CORE-535/cody-clients-migrate-ctas-to-live-links. ## Test plan 1. Tested CTA eligibility on dotcom, and enterprise instances 2. Checked dismiss notifications did not break webview 3. Checked links and confirmed that they matched with designs 4. Switched across multiple accounts and everything still worked <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. -->
taiyab
pushed a commit
that referenced
this pull request
Feb 3, 2025
Fixes typo introduced in #6803 ## Test plan Ran locally, confirmed text change has been applied to dotcom users only <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CTA links and eligibility logic, see Loom and CODY-4659 for full details
https://www.loom.com/share/2222084d04a14e1ba080b06c92207a19?sid=67bc08e2-e284-4616-92e4-1f087145a480
Closes https://linear.app/sourcegraph/issue/CORE-535/cody-clients-migrate-ctas-to-live-links.
Test plan