chat ui: remove user avatars, remove speaker name from follow-up message #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user knows who they are, why show it next to every message? It clutters the UI. So I removed the avatar from the human messages (we still have the avatar in the top right). I also removed the name from the follow-up message. It doesn't add anything. Ideally we'd remove the "user name" every where but when I did that, the layout looked kinda bad because there was still the 'split into chat' button.
beyang
approved these changes
Feb 6, 2025
|
@mrnugget should the LLM avatar also be removed too? now it looks off centered from the left. I personally don't mind the avatar being there, it keeps all the icons consistent on the left. But if we're going to remove it maybe just remove the name entirely
|
You mean the user name? Or the model name? |
the username. I think we should either do all avatar, no names, or only names no avatars. I think it feels inconsistent now, theres a name (no avatar), SG icon, LLM icon + name in a single turn of the chat |
sqs
pushed a commit
that referenced
this pull request
Feb 7, 2025
…age (#6981) The user knows who they are, why show it next to every message? It clutters the UI. So I removed the avatar from the human messages (we still have the avatar in the top right). I also removed the name from the follow-up message. It doesn't add anything. Ideally we'd remove the "user name" every where but when I did that, the layout looked kinda bad because there was still the 'split into chat' button. ## Before  ## After  ## Test plan - N/A
julialeex
pushed a commit
that referenced
this pull request
Feb 7, 2025
… follow-up message (#7009) The user knows who they are, why show it next to every message? It clutters the UI. So I removed the avatar from the human messages (we still have the avatar in the top right). I also removed the name from the follow-up message. It doesn't add anything. Ideally we'd remove the "user name" every where but when I did that, the layout looked kinda bad because there was still the 'split into chat' button. ## Before  ## After  ## Test plan - N/A <br> Backport 127d52c from #6981 Co-authored-by: Thorsten Ball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user knows who they are, why show it next to every message? It clutters the UI. So I removed the avatar from the human messages (we still have the avatar in the top right).
I also removed the name from the follow-up message. It doesn't add anything.
Ideally we'd remove the "user name" every where but when I did that, the layout looked kinda bad because there was still the 'split into chat' button.
Before
After
Test plan