Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

codeintel: Add scheme to frontend URL in indexer #11120

Merged
merged 1 commit into from
May 29, 2020

Conversation

efritz
Copy link
Contributor

@efritz efritz commented May 29, 2020

Dotcom is seeing a lot of errors like

Post sourcegraph-frontend-internal/.api/lsif/upload?commit=6a8421bcff44c2a9889075724070baaebf8dcd72&indexerName=lsif-go&repository=github.com%2Frobfig%2Fcron: unsupported protocol scheme ""+

because the SRC_FRONTEND_URL is a host/port pair only.

@efritz efritz requested a review from a team as a code owner May 29, 2020 22:12
@efritz efritz requested a review from shrouxm May 29, 2020 22:12
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #11120 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #11120   +/-   ##
=======================================
  Coverage   46.39%   46.39%           
=======================================
  Files        1367     1367           
  Lines       77136    77136           
  Branches     6663     6716   +53     
=======================================
  Hits        35786    35786           
  Misses      37951    37951           
  Partials     3399     3399           
Flag Coverage Δ
#go 50.47% <0.00%> (ø)
#storybook 6.88% <ø> (ø)
#typescript 35.84% <ø> (ø)
#unit 46.18% <0.00%> (ø)
Impacted Files Coverage Δ
...e-code-intel-indexer/internal/indexer/processor.go 0.00% <0.00%> (ø)

1 similar comment
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #11120 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #11120   +/-   ##
=======================================
  Coverage   46.39%   46.39%           
=======================================
  Files        1367     1367           
  Lines       77136    77136           
  Branches     6663     6716   +53     
=======================================
  Hits        35786    35786           
  Misses      37951    37951           
  Partials     3399     3399           
Flag Coverage Δ
#go 50.47% <0.00%> (ø)
#storybook 6.88% <ø> (ø)
#typescript 35.84% <ø> (ø)
#unit 46.18% <0.00%> (ø)
Impacted Files Coverage Δ
...e-code-intel-indexer/internal/indexer/processor.go 0.00% <0.00%> (ø)

@efritz efritz merged commit 44ea971 into master May 29, 2020
@efritz efritz deleted the indexer-frontend-url-scheme branch May 29, 2020 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant