Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add progress extension API #1375

Merged
merged 9 commits into from
Dec 14, 2018
Merged

Add progress extension API #1375

merged 9 commits into from
Dec 14, 2018

Conversation

felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented Dec 13, 2018

Ref #947

2018-12-13 14 46 56

@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #1375 into master will decrease coverage by 0.08%.
The diff coverage is 8.57%.

Impacted Files Coverage Δ
shared/src/extensions/controller.ts 0% <0%> (ø) ⬆️
shared/src/notifications/Notifications.tsx 0% <0%> (ø) ⬆️
shared/src/notifications/NotificationItem.tsx 0% <0%> (ø) ⬆️
shared/src/notifications/notification.ts 0% <0%> (ø) ⬆️
shared/src/api/client/services/notifications.ts 100% <100%> (ø) ⬆️
shared/src/api/client/connection.ts 84.78% <20%> (-8.08%) ⬇️
shared/src/api/client/api/windows.ts 57.69% <20.83%> (-32.31%) ⬇️
shared/src/api/extension/api/windows.ts 59.57% <5%> (-40.43%) ⬇️

Copy link
Member

@sqs sqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level, this looks exactly right. 👍

@felixfbecker felixfbecker changed the title WIP: Add progress extension API Add progress extension API Dec 13, 2018
@felixfbecker felixfbecker requested review from sqs, chrismwendt and lguychard and removed request for chrismwendt and lguychard December 13, 2018 13:54
@felixfbecker
Copy link
Contributor Author

Ready for review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants