This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: add WildcardAllValue and docs #30997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated Grafana 'all' value introduced in https://github.com/sourcegraph/sourcegraph/pull/29481 does not work very well for all cases, especially for
OptionsQuery
where we can get a huge result set.This PR creates an explicit option,
WildcardAllValue
, along with documentation on when and why to use it as well as why we don't use a wildcard by default.Test plan
sg.overwrite.yaml:
Set to 12 hours, go to Executor -> Executor: Compute instance metrics