Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

monitoring: add WildcardAllValue and docs #30997

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Feb 10, 2022

The generated Grafana 'all' value introduced in https://github.com/sourcegraph/sourcegraph/pull/29481 does not work very well for all cases, especially for OptionsQuery where we can get a huge result set.

This PR creates an explicit option, WildcardAllValue, along with documentation on when and why to use it as well as why we don't use a wildcard by default.

Test plan

sg.overwrite.yaml:

commands:
  prometheus:
    install: |
      gcloud container clusters get-credentials cloud --zone us-central1-f --project sourcegraph-dev
    cmd: |
      kubectl port-forward svc/prometheus -n prod 9090:30090
sg start monitoring

Set to 12 hours, go to Executor -> Executor: Compute instance metrics

image

@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 33c71b3...91a0dc6.

Notify File(s)
@slimsag monitoring/definitions/executor.go
monitoring/definitions/git_server.go
monitoring/definitions/zoekt.go
monitoring/monitoring/monitoring.go
@sourcegraph/distribution monitoring/definitions/executor.go
monitoring/definitions/git_server.go
monitoring/definitions/zoekt.go
monitoring/monitoring/monitoring.go

Copy link
Contributor

@Strum355 Strum355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bobheadxi bobheadxi merged commit f182340 into main Feb 10, 2022
@bobheadxi bobheadxi deleted the fix-exeuctor-dashboard branch February 10, 2022 20:01
@bobheadxi bobheadxi added the dx Issues and PRs related to developer experience concerns label Feb 10, 2022
davejrt pushed a commit that referenced this pull request Feb 15, 2022
The generated Grafana 'all' value introduced in #29481 does not work very well for all cases, especially for OptionsQuery where we can get a huge result set.

This PR creates an explicit option, WildcardAllValue, along with docs on when and why to use it as well as why we don't use a wildcard by default.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dx Issues and PRs related to developer experience concerns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants