This repository was archived by the owner on Sep 30, 2024. It is now read-only.
hackathon - search/notebook: basic notebooks query #33170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a basic end-to-end query that searches the full "notebook name" (namespace + title) with a simple
ILIKE
query. The query emulates how normal search works by replacing spaces with wildcards so you can be pretty loose with your query.Sharing code with
enterprise/.../notebooks
: we could possibly refactor this so that it lives in the same store as other notebooks stuff, but register it as the handler for the notebook search job from an init function. That said it makes sense, perhaps, to have the DB queries live here so that we can specialize it for search. It would be nice to share the permissions filter at least, however - not sure where this would live.Stacked on https://github.com/sourcegraph/sourcegraph/pull/33161
Kapture.2022-03-28.at.17.48.03.mp4