Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] allow all ksizes for protein input #576

Merged
merged 4 commits into from
Dec 27, 2018

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Dec 13, 2018

Addresses #575

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files          25       25           
  Lines        3786     3786           
  Branches       37       37           
=======================================
  Hits         3352     3352           
  Misses        434      434
Impacted Files Coverage Δ
sourmash/commands.py 89.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7379c...ab66319. Read the comment docs.

@ctb ctb changed the title allow all ksizes for protein input [WIP] allow all ksizes for protein input Dec 26, 2018
@ctb
Copy link
Contributor

ctb commented Dec 26, 2018

hi @bluegenes could you add a test, please? thx! no hurry.

Please change title to [MRG] when it's ready for review.

Also, please update from latest master. Note that if you put PR branches in the dib-lab/sourmash repo (you should have permissions) then anyone in dib-lab can update from master for you.

@bluegenes bluegenes changed the title [WIP] allow all ksizes for protein input [MRG] allow all ksizes for protein input Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants