use empty string if no url

sourmash-bio · May 20, 2024 · d0a3a74 · d0a3a74
1 parent 32f66ae
commit d0a3a74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/directsketch.rs b/src/directsketch.rs
@@ -532,7 +532,7 @@ pub fn failures_handle(
                         accession,
                         name,
                         moltype,
-                        url.expect("Can't convert url").as_str()
+                        url.map(|u| u.to_string()).unwrap_or("".to_string())
                     );
                     // Attempt to write each record
                     if let Err(e) = writer.write_all(record.as_bytes()).await {

diff --git a/tests/test_gbsketch.py b/tests/test_gbsketch.py
@@ -403,9 +403,10 @@ def test_gbsketch_bad_acc_fail(runtmp, capfd):
     print(captured.out)
     print(captured.err)
     assert "Error: No signatures written, exiting." in captured.err
-    
+
 
 def test_gbsketch_version_bug(runtmp):
+    # test for bug where we didn't check version correctly
     acc_csv = get_test_data('acc-version.csv')
     output = runtmp.output('simple.zip')
     failed = runtmp.output('failed.csv')