Using platform resources instead of shelling out #197
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Thank you for sharing your excellent cookbook! I have been finding it very useful.
This PR is more for discussion than an actual merge candidate. I have been hitting an issue similar to #194 while trying to use the :redeploy action, and I think the problem is due to the timing between when platform resources are processed (embedded into the resource collection) vs when the shelled out commands are run. If the platform resources defined in the container provider executes immediately everything works fine. What I am seeing currently is the
docker rm
shellout execute prior to theservice
resource's:stop
action, leading to the following error:If I replace the shellout calls with
execute
resources (as shown below) all the commands process just as the code reads and work perfectly (for my use case, it very well may have broken every other one).