Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library cookbook refactor #74

Merged
merged 18 commits into from
Aug 10, 2021
Merged

Library cookbook refactor #74

merged 18 commits into from
Aug 10, 2021

Conversation

bmhughes
Copy link
Contributor

@bmhughes bmhughes commented May 13, 2021 •
edited
Loading

Description

  • Refactor as a library cookbook
  • Restore support for Debian/Ubuntu

Issues Resolved

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@bmhughes bmhughes self-assigned this May 13, 2021
@the-label-bot
Copy link

the-label-bot bot commented May 13, 2021

Kind Prediction: refactor
Confidence: 0.971

Provide the bot with feedback using a 👍 or 👎!

@the-label-bot

This comment has been minimized.

Sign in to view
@bmhughes bmhughes mentioned this pull request May 13, 2021
Closed
2 tasks
@bmhughes bmhughes force-pushed the library-cookbook-refactor branch from 93fc528 to c295b70 Compare May 13, 2021 17:08
tas50
tas50 reviewed May 13, 2021
View reviewed changes
tas50
tas50 reviewed May 13, 2021
View reviewed changes
tas50
tas50 reviewed May 13, 2021
View reviewed changes
tas50
tas50 reviewed May 13, 2021
View reviewed changes
tas50
tas50 reviewed May 13, 2021
View reviewed changes
@ramereth
Copy link
Contributor

FWIW I'd like to get a proper Sous Chefs adoption release out the door (plus Chef 17 updates) before we deal with this refactor. But of course keep working on it.

@bmhughes
Copy link
Contributor Author

FWIW I'd like to get a proper Sous Chefs adoption release out the door (plus Chef 17 updates) before we deal with this refactor. But of course keep working on it.

Yeh that makes sense, I’ve been running this fork internally for probably a year or so now and had completely forgotten I’d done it. Hence the state it’s in.

@bmhughes bmhughes force-pushed the library-cookbook-refactor branch from b80cd14 to a1e5d63 Compare May 14, 2021 20:32
@the-label-bot
Copy link

the-label-bot bot commented May 14, 2021

Size Prediction: huge
Confidence: 0.999

This will take someone quite a while to understand and review.
Recommendation: Split this into smaller contributions.
The maintainers will thank you!

Provide the bot with feedback using a 👍 or 👎!

@bmhughes bmhughes force-pushed the library-cookbook-refactor branch 7 times, most recently from 56fce2f to e3c51cf Compare May 15, 2021 17:59
@bmhughes
Copy link
Contributor Author

This is probably 99% done now cookbook wise. Just the adoption and kitchen testing to sort out as it's a royal pain in the arse 🤔

@bmhughes bmhughes force-pushed the library-cookbook-refactor branch 2 times, most recently from ed0c514 to b0c34a9 Compare May 15, 2021 19:42
@bmhughes bmhughes force-pushed the library-cookbook-refactor branch 3 times, most recently from 27f2960 to 00f774f Compare August 8, 2021 14:13
bmhughes added 2 commits August 8, 2021 15:14
@bmhughes
Initial library refactoring
f903e36 
1. Restore support for Debian based distros.
2. Correct chef workstation package name in Travis config.
3. Linting fixes.
4. Add CentOS 8 testing.
5. Add Debian 10 testing.
6. Set all resources unified_mode
7. Create selinux_boolean resource
8. Remove attributes and recipes
9. Refactor install resource
10. Refactor selinux_state resource
11. Add description to resource properties
@bmhughes
Split kitchen tests into state groups
75f4191
@bmhughes bmhughes force-pushed the library-cookbook-refactor branch 2 times, most recently from 87a14dc to 211e0ba Compare August 8, 2021 17:21
bmhughes added 2 commits August 8, 2021 18:23
@bmhughes
Refactor module resource and libraries
81fea6a 
Refactor libraries and resource to remove complexity due to SELinux
CIL which removes module version numbers and thus the need to check
them.
@bmhughes
Update testing for refactoring
204d4fd
@bmhughes bmhughes force-pushed the library-cookbook-refactor branch from 211e0ba to ff4e527 Compare August 8, 2021 17:23
@bmhughes bmhughes force-pushed the library-cookbook-refactor branch from ff4e527 to 0870563 Compare August 8, 2021 17:26
@bmhughes bmhughes requested a review from damacus August 9, 2021 11:39
@damacus damacus merged commit 762c5af into main Aug 10, 2021
@damacus damacus deleted the library-cookbook-refactor branch August 10, 2021 11:05
@kitchen-porter
Copy link
Contributor

Released as: 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tas50 tas50 tas50 left review comments

@damacus damacus damacus approved these changes

@ramereth ramereth Awaiting requested review from ramereth

Assignees

@bmhughes bmhughes

Labels
Release: Major Release to Chef Supermarket as a major change when merged
Projects
None yet
Milestone
No milestone
6 participants
@bmhughes @ramereth @kitchen-porter @damacus @tas50 @xorimabot