Skip to content

Commit

Permalink
Check all places with check_mode: no for side effects (kubernetes-s…
Browse files Browse the repository at this point in the history
…igs#8573)

and fix the one with side effect.

Also removes `notify` from this task as the task has `changed_when: false`
and notify is not going to fire.
  • Loading branch information
fungusakafungus authored and LuckySB committed Jun 29, 2023
1 parent 44f3b42 commit f59cc77
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions roles/etcd/tasks/gen_certs_script.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,9 @@
executable: /bin/bash
no_log: true
changed_when: false
check_mode: no
when: (('calico_rr' in groups and inventory_hostname in groups['calico_rr']) or
inventory_hostname in groups['k8s_cluster']) and
sync_certs|default(false) and inventory_hostname not in groups['etcd']
notify: set etcd_secret_changed

- name: Gen_certs | check certificate permissions
file:
Expand Down

0 comments on commit f59cc77

Please sign in to comment.