MerkleID: add check for typof configParams.endpoint on extendId (preb…

…id#7611) * Chore: Added check for typof configParams.endpoint on extendId * Chore: Fixed various test issues * Chore: Removed stray console.log Console Log * Removed Package-lock.json * Chore: Added back original package-lock.json
sovrn · Jan 10, 2022 · 5c2ae02 · 5c2ae02
1 parent 4db903f
commit 5c2ae02
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/modules/merkleIdSystem.js b/modules/merkleIdSystem.js
@@ -149,6 +149,11 @@ export const merkleIdSubmodule = {
     logInfo('User ID - merkleId stored id ' + storedId);
     const configParams = (config && config.params) || {};
 
+    if (typeof configParams.endpoint !== 'string') {
+      logWarn('User ID - merkleId submodule endpoint string is not defined');
+      configParams.endpoint = ID_URL
+    }
+
     if (consentData && typeof consentData.gdprApplies === 'boolean' && consentData.gdprApplies) {
       logError('User ID - merkleId submodule does not currently handle consent strings');
       return;

diff --git a/test/spec/modules/konduitWrapper_spec.js b/test/spec/modules/konduitWrapper_spec.js
@@ -53,7 +53,6 @@ describe('The Konduit vast wrapper module', function () {
       const callback = sinon.spy();
       processBids({ bid, callback });
       server.respond();
-
       expect(server.requests.length).to.equal(1);
 
       const requestBody = JSON.parse(server.requests[0].requestBody);

diff --git a/test/spec/modules/merkleIdSystem_spec.js b/test/spec/modules/merkleIdSystem_spec.js
@@ -192,6 +192,24 @@ describe('Merkle System', function () {
 
       expect(id.id).to.exist.and.to.equal(storedId);
     });
+    it('extendId() should warn on missing endpoint', function () {
+      let config = {
+        params: {
+          ...CONFIG_PARAMS,
+          endpoint: undefined
+        },
+        storage: STORAGE_PARAMS
+      };
+
+      let yesterday = new Date(Date.now() - 86400000).toUTCString();
+      let storedId = {value: 'Merkle_Stored_ID', date: yesterday};
+
+      let submoduleCallback = merkleIdSubmodule.extendId(config, undefined,
+        storedId).callback;
+      submoduleCallback(callbackSpy);
+      expect(callbackSpy.calledOnce).to.be.true;
+      expect(utils.logWarn.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule endpoint string is not defined');
+    });
 
     it('extendId() callback on configured storageParam.refreshInSeconds', function () {
       let config = {