Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #27

Merged
merged 152 commits into from
Dec 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
d8f43de
Adding Medianet outstream renderer support (#5854)
c3p-0 Oct 20, 2020
449a9fa
PR-review: fixed getFloor function name (#5876)
bretg Oct 20, 2020
5d9a0e6
Real Time Data Module - Phase3 (#5783)
omerDotan Oct 20, 2020
c4eb742
Audigent RTD Provider HaloId Support & RTD Phase 3 Compliance (#5777)
Oct 20, 2020
291caa1
[AD-963] - Update JW Player RTD Provider for compliance with RTD Modu…
karimMourra Oct 20, 2020
9c1d1a2
Reconciliation Real Time Data Provider (#5774)
vfedoseev Oct 20, 2020
01eb953
Update instream logic to account for multimp (#5872)
sdao-tl Oct 21, 2020
3423e7b
Verizon Media user id module (#5786)
slimkrazy Oct 21, 2020
820ec1d
Use new ad request format by default in TheMediaGrid Bid Adapter (#5840)
TheMediaGrid Oct 21, 2020
73b4fc7
Floors Module update to include floorMin (#5805)
mmoschovas Oct 21, 2020
372fbbd
Prebid 4.13.0 Release
mike-chowla Oct 21, 2020
73d880f
Increment pre version
Oct 21, 2020
d3c0ded
configurable TTL for impressions (#5880)
jrosendahl Oct 21, 2020
05606c6
PulsePoint Adapter: Fix on multi-format support (#5857)
anand-venkatraman Oct 22, 2020
0576ee2
ID5 user id module: migrate publishers to use local storage instead o…
smenzer Oct 22, 2020
b2ecc7e
add us_privacy to id5 id module (#5858)
smenzer Oct 22, 2020
081a9f2
Rubicon Bid Adapter - Interpret response adds new meta values (#5864)
mmoschovas Oct 22, 2020
22677c1
[Synacormedia] Config override for site.domain property (#5885)
slaufer Oct 23, 2020
da480f2
AOL Adapter: User ID Support (#5886)
slimkrazy Oct 23, 2020
fb95850
the code to require local storage will be released in 4.14.0 not 4.13…
smenzer Oct 23, 2020
6360492
fix: schain complete can be 0 (#5902)
Oct 27, 2020
894c1d7
[AD-1020] JWPlayer RTD: Obtain targeting params from FPD (#5892)
karimMourra Oct 27, 2020
6f531d5
Add support for Publisher Common ID Module (#5871)
madma Oct 27, 2020
5bda2f1
Liveintent id module doesn't fall back to the default implementations…
Oct 27, 2020
7da5dad
aol bid adapter: support IE (#5894)
robertrmartinez Oct 28, 2020
9d37b25
add check for config to make sure its defined (#5873)
Fawke Oct 28, 2020
9dbc998
Prebid 4.14.0 Release
smenzer Oct 28, 2020
d966829
Increment pre version
smenzer Oct 28, 2020
78a2d28
Media type renderers (#5760)
MikeSperone Oct 29, 2020
9a75d26
Added GVL_ID & addtl_consent for smartadserverBidAdapter (#5870)
lowendavid Oct 29, 2020
51f2405
New krushmedia Prebid.js adapter (#5833)
Krushmedia Oct 30, 2020
348a4f5
eTarget: adapter update (#5881)
etargetse Oct 30, 2020
e3a9c60
DMX Fix video bug (#5910)
stevealliance Nov 2, 2020
eb55e67
fix failing lint errors on circle ci (#5918)
Fawke Nov 2, 2020
1a76a46
IX missing sizes testing and diagnosis (#5856)
ix-certification Nov 2, 2020
ae1b4d7
Add apacdex bid adapter & Merge valueimpression, quantumdex to apacde…
thuyhq Nov 2, 2020
640a3cd
Adkernel: basic meta forwarding (#5836)
ckbo3hrk Nov 2, 2020
78d5117
Add skip params to Beachfront adapter (#5847)
jsalis Nov 2, 2020
39df31f
AMX RTB: improve URL handling in request (#5905)
nickjacob Nov 2, 2020
d19f4ca
feat: add the elapsed time to events for debugging (#5868)
gpolaert Nov 2, 2020
024cac8
remove 'only' to run all tests (#5926)
Fawke Nov 3, 2020
07ec2bc
Add Auction Options Config (#5787)
ncolletti Nov 3, 2020
84649e8
TL: Add GVLID, update validation method, add unit tests (#5904)
sdao-tl Nov 3, 2020
38a1c8e
rubicon - support all userIds (#5923)
harpere Nov 3, 2020
97766fb
Adds tcf v2 support (#5883)
onetag-dev Nov 3, 2020
1da9ca6
get dynamic ttl from the server response (#5896)
liranbaruch Nov 4, 2020
fa2394f
Teads adapter: add Global Vendor Id (GDPR enforcement) (#5929)
nailyk Nov 4, 2020
7bbb053
Smaato: Add userIds to BidRequest (#5927)
sbrosinski Nov 4, 2020
7729bb7
Mediasquare: add native and video support (#5823)
matthieularere-msq Nov 4, 2020
31e00f2
33Across: Added Video Support (#5884)
curlyblueeagle Nov 4, 2020
014b65f
Prebid 4.15.0 Release
robertrmartinez Nov 4, 2020
d3eec3a
Increment pre version
robertrmartinez Nov 4, 2020
28473bc
Improve Digital adapter: eids support (#5935)
jbartek25 Nov 5, 2020
bb60431
Adkernel: andbeyond alias (#5922)
ckbo3hrk Nov 5, 2020
f9fdc9c
LunamediaHB bid adapter (#5906)
lunamedia Nov 6, 2020
7efc333
Add User ID Targeting to googletag.cmd as a fallback when GPT API is …
lyubomirshishkov Nov 9, 2020
83279da
No bid version 1.2.9 (#5794)
redaguermas Nov 9, 2020
49f0be3
EMX Adding Schain forwarding (#5946)
EMXDigital Nov 9, 2020
0a6b322
pubGENIUS bid adapter: fix bug that requestBids timeout is not respec…
edmonl Nov 9, 2020
ffc6210
Updated the text in line 292 (#5937)
rimaburder-index Nov 9, 2020
7070b1f
Update for Qwarry bid adapter (#5936)
pro-nsk Nov 9, 2020
9676ce0
Adagio Bid Adapter: support UserId's (#5938)
osazos Nov 10, 2020
690709b
userId module: fix auctionDelay submodules with callbacks (#5891)
FilipStamenkovic Nov 10, 2020
fee75c7
fix circle ci failing lint error (#5952)
Fawke Nov 10, 2020
1bbe837
PR-Review process: fleshing out RTD review (#5948)
bretg Nov 10, 2020
0de9caf
delete pubcommon test cookie for domainOverride after writing it in a…
smenzer Nov 10, 2020
e065e87
Gamoshi - Add new alias (#5895)
Nov 10, 2020
7d97720
adot: add publisher id retrieval from bidder config (#5928)
mlequain Nov 11, 2020
2b0bd53
Lemma bid adapter: Add user sync support (#5934)
lm-abhijit Nov 12, 2020
954acdb
ID Library (#5863)
SKOCHERI Nov 12, 2020
17beca2
Zeta-Prebid (#5813)
mwehr-zeta Nov 12, 2020
d5c2c8f
Prebid 4.16.0 Release
robertrmartinez Nov 12, 2020
ef7fb86
Increment pre version
robertrmartinez Nov 12, 2020
09468bf
[AD-1043] JW Player RTD - add targeting info to bid.rtd (#5950)
karimMourra Nov 13, 2020
5f36be9
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
92a9a09
Update pubCommonIdSystem.js (#5974)
jdwieland8282 Nov 15, 2020
840c04d
[CriteoId] Add local storage check and migrate cookie check to use St…
jesusalber1 Nov 16, 2020
fb32955
Audigent RTD configurable per-bidder segment mappings (#5903)
Nov 16, 2020
ac686e5
added feature/getNoBidsForAdUnitCode function (#5932)
Nov 16, 2020
a4a194c
update quantcastBidAdapter to make user sync flag non-constant (#5949)
mckurt Nov 16, 2020
a126dcf
Update for Qwarry bid adapter: onBidWon hotfix (#5955)
pro-nsk Nov 16, 2020
1664f4e
FIX typo's in CONTRIBUTING (#5956)
jsut Nov 16, 2020
5aa0fe6
Add a note to the readme about adapter aliases (#5968)
jsut Nov 16, 2020
c04bd6d
update quantcastBidAdapter to pass quantcast fpa in the bid request (…
mckurt Nov 17, 2020
fe7acf8
improve console ogging of user id module by listing all user id modul…
smenzer Nov 17, 2020
f6e3465
Add IdentityLink support to Beachfront adapter (#5977)
jsalis Nov 17, 2020
f47287e
Vidazoo Adapter: Feature/spec-gvlid (#5980)
uditalias Nov 17, 2020
842f21c
Update sharedIdSystem.js with GVLID (#5988)
jdwieland8282 Nov 17, 2020
18afadd
FreeWheel SSP - Added GDPR to userSync (#5969)
evalenciano Nov 17, 2020
b73ab25
Fix request size validate (#5951)
relaido Nov 17, 2020
96989ca
Prebid Server Bid Adapter: Expose errors and server response times al…
robertrmartinez Nov 17, 2020
71e9cc7
Between: schain support was added (#5982)
ignat-one Nov 18, 2020
efbc9d3
fix source lowercase bug (#5989)
robertrmartinez Nov 18, 2020
da87e57
Add consent to sync url (#5981)
SmartyAdman Nov 18, 2020
c308898
add provider as an option in id5 config params to identity prebid ide…
smenzer Nov 18, 2020
8340be8
Prebid 4.17.0 Release
Nov 18, 2020
a84b4e9
Increment pre version
Nov 18, 2020
57fb14c
Instream video support for Yieldmo adapter (#5973)
arconamagi Nov 19, 2020
d5a08ce
PubxAi analytics adapter (#5915)
Nov 19, 2020
6fea844
init bizzclick prebid.js adapter (#5914)
BizzClick Nov 19, 2020
172df7f
Appnexus: Update maintainer (#5987)
jaiminpanchal27 Nov 19, 2020
578213c
Fix import warning for webpack 5 (#5933)
GLStephen Nov 20, 2020
c98a633
PulsePoint Adapter: Fixing issue with multi-format requests (#5995)
anand-venkatraman Nov 20, 2020
1e98aef
Fix/test code set cookie (#5996)
relaido Nov 20, 2020
04c941f
Honour bidFloor key in params (#5999)
monis0395 Nov 20, 2020
8135e5d
adform adapter - allow to pass custom eids param (#6008)
braizhas Nov 21, 2020
e5e899d
Add video response type param to Beachfront adapter (#6011)
jsalis Nov 21, 2020
022bcea
fix appnexus segment field format (#6013)
Nov 21, 2020
cebae4a
New haxmedia bidder adapter (#6001)
haxmediagithub Nov 23, 2020
8930be4
[Triplelift] Add advertiserDomains support (#5993)
Nov 24, 2020
015c48b
Browsi RTD provider docs (#5920)
omerDotan Nov 24, 2020
1f24ee4
Add Geoedge RTD provider submodule (#5869)
GeoEdge-r-and-d Nov 24, 2020
678ffdf
sspBC adapter: update to v4.6 (notifications, user sync) (#5941)
wojciech-bialy-wpm Nov 25, 2020
99fe1a7
Appnexus - Send CriteoId in eids array. (#6025)
Fawke Nov 25, 2020
e202cf5
allow users to be sent to dmx even when gdpr is configured in prebid …
MenelikTucker-districtm Nov 25, 2020
1137a64
Admixer adapter update - add user syncs (#6024)
Galphimbl Nov 25, 2020
939c455
Add support for `backupOnly` option in mediaType video renderer (#5972)
osazos Nov 25, 2020
18086e4
New mobfox prebid adapter (#5978)
mobfxoHB Nov 30, 2020
4b3faf4
Update adkernelBidAdapter.js (#5957)
Avimobi Nov 30, 2020
a7beb57
RP Analytics Adapter update for UTM KVs (#5998)
mmoschovas Nov 30, 2020
57ef24a
remove pubcommon optout from user id module checks (#5994)
smenzer Nov 30, 2020
4638dff
ID5 ID module - pass gdpr and usp parameters in body instead of query…
smenzer Nov 30, 2020
6f147c6
Prebidmanager analytics adapter: fix console error when utm is null a…
Prebid-Manager Dec 1, 2020
d5f228b
Rp adapter unit tests - userid mod support (#5985)
nickllerandi Dec 1, 2020
0820790
Read floor data in analytic + support for Criteo Id (#6003)
bjorn-lw Dec 1, 2020
24cae18
Admixer adapter update - add deal id (#6042)
Galphimbl Dec 1, 2020
2609a1b
FID-251: Update Reconciliation RTD Provider to 2.1 (#6037)
vfedoseev Dec 1, 2020
6963bb3
grid Bid Adapter: Fix empty bidfloor (#6031)
TheMediaGrid Dec 1, 2020
804d76c
Add fabrick to eids file (#6022)
andersonbd1 Dec 1, 2020
1739faf
Added pubProvidedIdSystem to .submodules.json (#6056)
mkendall07 Dec 1, 2020
30fa056
Add getUserSync implementation into adapter (#6052)
Krushmedia Dec 1, 2020
a52e943
.babelrc.js - changed IE target from 10 to 11 (#6035)
Slind14 Dec 2, 2020
ca45244
6060 Fix for: Changing globalVarName causes gulp serve tests to fail …
pm-harshad-mane Dec 2, 2020
03ed221
update ttl value (#6041)
steve-a-districtm Dec 2, 2020
6d29360
oneVideo Adapter - Custom Key Value Pair targeting support (SAPR-1547…
adam-browning Dec 2, 2020
53b0ed0
appnexusBidAdapter - remove tpuids (#6074)
Fawke Dec 2, 2020
bb501f0
Rubicon Bid Adapter remove rp_floor param if floor not set (#6062)
mmoschovas Dec 2, 2020
571c6a1
Prebid 4.18.0 Release
jsnellbaker Dec 2, 2020
b8eb346
increment pre version
jsnellbaker Dec 2, 2020
cfe9786
LKQD: update adapter to include new parameters (#6033)
david-carver Dec 2, 2020
19da021
pubGENIUS bid adapter: support video (#6040)
edmonl Dec 3, 2020
ddebc4a
Add Optional Params to Concert Adapter (#6064)
jeninedrew Dec 4, 2020
2b730a8
adagioBidAdapter: add Video support (#6038)
osazos Dec 4, 2020
5552473
Not using utils.isEmpty on non objects (#6036)
telariaEng Dec 4, 2020
4b0b82f
Update adkernelBidAdapter.js for client alias (#6055)
iskmerof Dec 4, 2020
8107da6
Add GVLID RichaudienceAdapter (#6071)
richaudience Dec 4, 2020
8ea3f3b
GumGum: sets mediaType of bidRequest depending on product id (#6066)
susyt Dec 4, 2020
93536f0
pubgenius: remove video cache key to be future-proof (#6081)
edmonl Dec 4, 2020
b9a4cc6
fix pubgenius unit test (#6090)
jsnellbaker Dec 7, 2020
5f6dab3
6012: Fix for passing US Privacy string in buildVideoUrl and buildAdp…
pm-harshad-mane Dec 7, 2020
dbd0d84
fix prebid server playerwidth and height (#6073)
ReinoutStevens Dec 7, 2020
93f393a
Fix iframe __tcfapi arguments (#6058)
polo2ro Dec 7, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = {
"safari >=8",
"edge >= 14",
"ff >= 57",
"ie >= 10",
"ie >= 11",
"ios >= 8"
]
}
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Contributions are always welcome. To contribute, [fork](https://help.github.com/
commit your changes, and [open a pull request](https://help.github.com/articles/using-pull-requests/) against the
master branch.

Pull requests must have 80% code coverage before beign considered for merge.
Pull requests must have 80% code coverage before being considered for merge.
Additional details about the process can be found [here](./PR_REVIEW.md).

There are more details available if you'd like to contribute a [bid adapter](https://docs.prebid.org/dev-docs/bidder-adaptor.html) or [analytics adapter](https://docs.prebid.org/dev-docs/integrate-with-the-prebid-analytics-api.html).
Expand Down Expand Up @@ -59,7 +59,7 @@ When you are adding code to Prebid.js, or modifying code that isn't covered by a
Prebid.js already has many tests. Read them to see how Prebid.js is tested, and for inspiration:

- Look in `test/spec` and its subdirectories
- Tests for bidder adaptors are located in `test/spec/modules`
- Tests for bidder adapters are located in `test/spec/modules`

A test module might have the following general structure:

Expand Down
11 changes: 8 additions & 3 deletions PR_REVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Follow steps above for general review process. In addition, please verify the fo
- All bidder parameter conventions must be followed:
- Video params must be read from AdUnit.mediaTypes.video when available; however bidder config can override the ad unit.
- First party data must be read from [`fpd.context` and `fpd.user`](https://docs.prebid.org/dev-docs/publisher-api-reference.html#setConfig-fpd).
- Adapters that accept a floor parameter must also support the [floors module](https://docs.prebid.org/dev-docs/modules/floors.html) -- look for a call to the `getFloors()` function.
- Adapters that accept a floor parameter must also support the [floors module](https://docs.prebid.org/dev-docs/modules/floors.html) -- look for a call to the `getFloor()` function.
- Adapters cannot accept an schain parameter. Rather, they must look for the schain parameter at bidRequest.schain.
- The bidRequest page referrer must checked in addition to any bidder-specific parameter.
- If they're getting the COPPA flag, it must come from config.getConfig('coppa');
Expand Down Expand Up @@ -89,9 +89,14 @@ Documentation they're supposed to be following is https://docs.prebid.org/dev-do
Follow steps above for general review process. In addition:
- The RTD Provider must include a `providerRtdProvider.md` file. This file must have example parameters and document a sense of what to expect: what should change in the bidrequest, or what targeting data should be added?
- Try running the new sub-module and confirm the provided test parameters.
- Make sure the sub-module is making HTTP requests as early as possible, but not more often than needed.
- Confirm that the module
- is not loading external code. If it is, escalate to the #prebid-js Slack channel.
- is reading `config` from the function signature rather than calling `getConfig`.
- is sending data to the bid request only as either First Party Data or in bidRequest.rtd.RTDPROVIDERCODE.
- is making HTTPS requests as early as possible, but not more often than needed.
- doesn't force bid adapters to load additional code.
- Consider whether the kind of data the module is obtaining could have privacy implications. If so, make sure they're utilizing the `consent` data passed to them.
- make sure there's a docs pull request
- Make sure there's a docs pull request

## Ticket Coordinator

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ This runs some code quality checks, starts a web server at `http://localhost:999

### Build Optimization

The standard build output contains all the available modules from within the `modules` folder.
The standard build output contains all the available modules from within the `modules` folder. Note, however that there are bid adapters which support multiple bidders through aliases, so if you don't see a file in modules for a bid adapter, you may need to grep the repository to find the name of the module you need to include.

You might want to exclude some/most of them from the final bundle. To make sure the build only includes the modules you want, you can specify the modules to be included with the `--modules` CLI argument.

Expand Down
257 changes: 0 additions & 257 deletions integrationExamples/gpt/audigentSegments_example.html

This file was deleted.

Loading