Togglable tinted windows #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Changes: Localization
|
тесты не проходят, кушать нельзя |
AwareFoxy
reviewed
Nov 18, 2024
Resources/Locale/ru-RU/ss14-ru/prototypes/entities/structures/windows/window.ftl
Outdated
Show resolved
Hide resolved
…windows/window.ftl Co-authored-by: AwareFoxy <[email protected]>
AwareFoxy
requested review from
Tornado-Technology,
Vonsant and
AwareFoxy
and removed request for
Morb0
Tornado-Technology
requested changes
Nov 20, 2024
Это пиздец |
ТестированиеВыглядит круто, работает классно. Хотя есть пару моментов.
|
поддерживаю |
это я не смогу сделать |
Может я попробую это реализовать когда у меня время появится. Но так впринципе норм. |
Я могу описать как |
|
lzk блять нахуй ты резолвнул если нихуя не сделал и даже не прокоментил |
FireNameFN
requested changes
Feb 9, 2025
|
|
||
| public override void Initialize() | ||
| { | ||
| base.Initialize(); |
There was a problem hiding this comment.
Suggested change
| base.Initialize(); |
| SubscribeLocalEvent<ToggleableOccluderComponent, ComponentInit>(OnInit); | ||
| } | ||
|
|
||
| private void OnInit(EntityUid uid, ToggleableOccluderComponent comp, ComponentInit args) |
There was a problem hiding this comment.
Suggested change
| private void OnInit(EntityUid uid, ToggleableOccluderComponent comp, ComponentInit args) | |
| private void OnInit(Entity<ToggleableOccluderComponent> entity, ref ComponentInit args) |
| _signalSystem.EnsureSinkPorts(uid, comp.OnPort, comp.OffPort, comp.TogglePort); | ||
| } | ||
|
|
||
| private void OnSignalReceived(EntityUid uid, ToggleableOccluderComponent comp, ref SignalReceivedEvent args) |
There was a problem hiding this comment.
Suggested change
| private void OnSignalReceived(EntityUid uid, ToggleableOccluderComponent comp, ref SignalReceivedEvent args) | |
| private void OnSignalReceived(Entity<ToggleableOccluderComponent> entity, ref SignalReceivedEvent args) |
| @@ -111,6 +111,14 @@ | |||
| - type: Occluder | |||
| - type: StaticPrice | |||
| price: 70 | |||
| # Corvax-Next-Togglable-Tinted-Window-Start | |||
There was a problem hiding this comment.
Suggested change
| # Corvax-Next-Togglable-Tinted-Window-Start | |
| # Corvax-Next-TogglableTintedWindow-Start |
| - On | ||
| - Off | ||
| - Toggle | ||
| # Corvax-Next-Togglable-Tinted-Window-End |
There was a problem hiding this comment.
Suggested change
| # Corvax-Next-Togglable-Tinted-Window-End | |
| # Corvax-Next-TogglableTintedWindow-End |
| @@ -1,7 +1,8 @@ | |||
| ent-Window = окно | |||
| .desc = Смотри не заляпай. | |||
| # Corvax-Next-Togglable-Tinted-Window changed desc below | |||
There was a problem hiding this comment.
Suggested change
| # Corvax-Next-Togglable-Tinted-Window changed desc below | |
| # Corvax-Next-TogglableTintedWindow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Port space-wizards/space-station-14#30743
Почему / Баланс
cool feature
Ссылка на ветку
Технические детали
not really, don't know
Медиа
2024-08-07_17-32-43.mp4
Критические изменения
no
Список изменений
🆑