Fixes key combinations blocking single keys. #1472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radrark
requested review from
Acruid,
PJB3005 and
ZoldorfTheWizard
as code owners
|
Check if something like this PR works before changing stuff inside InputManager, since I'm pretty sure those checks are needed. |
|
Ok so this causes another issue. Should I close this PR and open another when I actually fix the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes space-wizards/space-station-14#2782
This changes the InputManager so that, when a key combination is pressed, the manager adds its subcombinations bindings to the list of binds to be triggered. For example, when you press Ctrl+A, the input manager adds TextSelectAll and MoveLeft to the list, instead of just TextSelectAll. So, if TextSelectAll doesn't get handled, MoveLeft is then triggered.
Also, I fixed the PackedIsSubPattern method but I noticed it isn't useful now. Anyways, I left it there.
I'm fairly new to C# so maybe this isn't the right way to fix the issue idk.