Isolate net messages in integration tests. #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests don't use Lidgren to connect client and send, instead they just use some in-process channels to communicate. Because of this, the original implementation of net messages *directly* passed the net message instances between client and server instances. This caused issues whenever content would mutate data in a NetMessage after it "passed through". Now we run the messages through WriteToBuffer() and ReadFromBuffer() so they pass through binary serialization. This means there's no more implicit sharing of the objects. Note that this requires some trickery: Lidgren's message types have internal constructors. Really ideally we'd change the engine to make this more testable... but that's a content breaking change. Instead I just added InternalsVisibleTo to Lidgren so we can mess with it. We maintain the library ourselves anyways I can do what I want. Fixes space-wizards#4836
This is necessary so that serialized types in the assembly can be picked up by NetSerializer. Have to disable automatic reflection on all entity systems/components that tests register manually right now, because otherwise tests break.
This isn't necessary anymore now that we have a thorough fix.
PJB3005
added a commit
to PJB3005/space-station-14-content
that referenced
this pull request
Jan 16, 2024
This didn't cause any issues because NetSerializer wasn't used in integration tests... until space-wizards/RobustToolbox#4838.
PJB3005
added a commit
to space-wizards/space-station-14
that referenced
this pull request
Jan 16, 2024
This didn't cause any issues because NetSerializer wasn't used in integration tests... until space-wizards/RobustToolbox#4838.
lzk228
added a commit
to lzk228/space-station-14-ua
that referenced
this pull request
Jan 20, 2024
* Fix emergency flare not igniting through verb menu. (#24027) Emergency flare ignites when activated through verb menu * Automatic changelog update * fix plushie rouny sprite (#24031) * Fix oxyburn energy not accounting for heatscale (#24023) * Remove spacepens (#23970) * Automatic changelog update * Updates aspid (#24014) * Remove AmmoTechFabCircuitboard from Thief objectives (#24037) * Automatic changelog update * Makes Eggs drawable with a syringe (#24042) -Makes Eggs drawable with a syringe * Automatic changelog update * Add a check for item size in the microwave system (#24026) * Add a check for item size in the microwave system * DataField suggestion * Merge TryComp with HasComp * Add datafield changeability for admins * Automatic changelog update * Make changelog script able to manage admin changelogs (#24033) * Make changelog script able to manage admin changelogs * I forgot to remove the comment * Yeah that should probably just be an exclusion instead. * Update Credits (#24057) Co-authored-by: PJBot <[email protected]> * Fix vending machine thank you flag timing (#24049) Fix thank you flag timing * Desk bells can be rung with activate (#24047) * Desk bells can be rung with activate Important * Remove obsoletions too while I'm at it. * Colorblind-compatible QM uniform sprites (#24055) colorblind-compatible qm drip * Remove archaic accent (#24052) * Automatic changelog update * Mayo (#24017) Mayo * Automatic changelog update * Species' melee changes (#24019) Changes Spider attack type to pierce, and gives them the bite anim. Lizards now have claw anim. * Automatic changelog update * Quick dialog fixes (#24046) Pressing "enter" on the last dialog box now confirms the dialog. Localize. * Fix error when switching to a screen without an inventory gui widget (#24059) * better deconversion (#23315) * add deconverted window * show deconverted window when deconverting + remove the role * webedit ops * antagonist -> revolutionary * evil * oh * eui ops --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Add admin logs for thermomachines (#24056) * Automatic changelog update * Add a neck gaiter into HOS's dresser (#24003) HOS's dresser now contains a neck gaiter * Automatic changelog update * Navmap UI enhancements (#23777) * label scaling wip * beacon toggle, cleanup * weh * caw * Smooth scaling, almost-selectable font size, Magnification count, zoom scale accuracy change, opacity * never asked for individual font sizes * zoom * format * Fixes CrewMonitor and PowerMonitor using the default tile color as text background instead of their custom tile colors * font customisation, needs UI elements * Station map rightclick now works * UI scale will keep the local systems in line * adjusting font size to UI scale * typo * fix RT version * putting cache back in its place * toggle labels moved to Examine * Automatic changelog update * no time limit on nukie syndicate bomb (#24022) implement * Automatic changelog update * Cvar to allow whitelisted players to bypass panic bunker (#23885) Among us * Hackable intercoms (#23984) * Enable wire interface for intercom * Implement BlockListening component and system * Implement ListenWireAction * Added cooldown/overload to mic wire pulse * Properly persist voicemask settings when user already has one. * Addressed requested changes * Added wire panel open/closed visuals * Automatic changelog update * Teleport fixes (#24064) - Teleport to physics center not transform center. - Fix NetEntity not being passed in. * Fix iron ore being called steel ore in the vein descriptions (#24066) Fix iron ore being called steel ore * box update (#24065) * meta update (#24067) * packed update (#24068) * Revert "Greyscale decal tweaks + additions" (#24069) * BUI bugfixes / improvements (#23881) * Fix ActivatableUIRequiresPowerCellComponent stopping power draw when one of two people closes the UI. Also fixes it to check UiKey properly. * Remove unnecessary CrewManifestViewer on PDAs This is for a pop-up crew manifest UI, which the PDA doesn't use. * Fix BoundUIClosedEvents that didn't check UI key/not correctly at least. Uses the new helper method in engine. * Fix drone (cargo shuttle) pilot console UI breaking if two people open it and one person closes it. * Fixes for disposal router/tagger UI. Code was badly copy pasted without changing identifiers, never worked. Also cleaned up some of the logic (text trimming, sounds). Also removed the "refuse to work if you have something in your active hand" check like why. * Avoid running most ActivatableUIComponent logic when closing a UI via toggle Activating the UI while it's already open closes it via toggle. Except it still ran 99% of the "attempting to open" logic which makes no sense. This probably fixes a bug or some other dumb behavior somewhere. * Bitch * Add greenshift preset (#24029) Co-authored-by: deltanedas <@deltanedas:kde.org> * Tail wagging (#19573) * MVP * Uncomment animated prototypes * Disable wagging on death * Move component to server * Looped tail animation * Apply front tail template * Disable animated markings globally * Add emote sending * Update documentation * Move locale * Use static instantAction & remove action on comp del * Use fluent POSS-ADJ * Update docs * Add copyright * Update copyright * Update license & copyright * Move to main directory & format meta.json * Fix path * Change namespace * Remove empty meta.json * Update * REMOVE unnecessary IsNullOrWhiteSpace check Co-authored-by: DrSmugleaf <[email protected]> * Move animated markings to main file * Use emotes * new * fix * fix * Tests, pls * fix dixel * Remove networked from wagging comp * Remove unused import * Remove unused imports * Move wagging comp to shared * Revert the emotes If we're getting it the action is better. --------- Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Entitylookup method renames (#23519) * Update submodule to 206.0.0 (#24072) * Add TryGetPrimaryDepartment to jobs system (#23317) * add primary departments * make command and station specific secondary * add a unit test * fixy * compile * webedit ops --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Make throwable star damage stamina (#23527) * feat(star.yml): make throwable star damage stamina * feat(Components): add new StaminaTresholdDamageOnEmbedComponent * feat(SharedProjectileSystem): update system with new events to change stamins treshold on embeed projectile remove / add * feat(StaminaSystem): update system with new subscriptions * feat(throwing_stars): update yml with new component * feat(StaminaDamageOnEmbed): add stamina damage on embeed * cleanup unused / ajust numbers * fix(StaminaSystem / OnEmbedComponent ) apply requested changes * Rest of the review * another warning --------- Co-authored-by: metalgearsloth <[email protected]> * Fix error when the client gets an Eui state message before its open message (#23610) * Fix error when the client gets an Eui state message before its open message * Revert "Fix error when the client gets an Eui state message before its open message" This reverts commit 440e2746ee8d77306f59ddea558eda32ec927f18. * Make all Eui msgs reliable ordered * Virtual items cleanup (#23912) * Virtual items cleanup * Detail * Review --------- Co-authored-by: metalgearsloth <[email protected]> * Cerberus has AI (#24028) * Automatic changelog update * Remove bad Dirty call introduced by PR #20778 (#24076) The HealOnBuckleHealingComponent is not in Shared/Client code, need not be networked, and cannot be dirty. * Fix admins unable to hide the coordinates debug monitor (#24084) Allow admins to hide the coords monitor * Suit Storage Visual Change (#23799) * Revert "New moth antennae and wing pair, Underwing (#23559)" This reverts commit 1b4f1ac. * Revert "Revert "New moth antennae and wing pair, Underwing (#23559)"" This reverts commit d2543d566cb398b4d7496e3f189cb638f826bf27. * dsd * sdst * sd * Plates & Cash gridinv visuals (#24075) * Automatic changelog update * Grave digging and decomposition (#23646) * Grave digging and decomposition * fix * update based on review comments * code review * remove unused field * Automatic changelog update * Nerf and Add More Reagent Slimes (#24087) * Nerf and Add More Chem Slimes * Whoops Redundancy * Automatic changelog update * decelerator nerf and projectile penetration mini refactor (#24032) * decelerator nerf and projectile fix * datafield name difference * forgot to add component * missed datafield styling * comment made summary * CanPenetrateComponent and CollisionLayer check. * Small comment changes * Automatic changelog update * Cryo Burn Chem - Aloxadone (#23980) Aloxadone (accidentally exploded first pr oops) * Automatic changelog update * Eye opening/closing is now possible while cuffed (#24097) u can now open and close your eyes while cuffed * Automatic changelog update * Nerf lava firestacks (#24100) * nerf lava firestacks * dode * Automatic changelog update * Cryogenic Sleep Units (#24096) * Cryogenic sleep units * pause map support * no more body deletion * Cryogenic Storage Units * boowomp * no more emag, no more dropping present people * Automatic changelog update * Action, Action Container, and Action Upgrade changes (#24005) * Added TransferActionWithNewAttached and TransferAllActionsWithNewAttached and OnActionAdded event method to ActionContainerSystem. These are needed where the action needs to have a different attached entity for usage. Fixed a bug with not being able to upgrade actions between levels. Added a way to grant and remove a singular action. * adds an action container component to mind on action added to fix tests * Swaps trycomp for hascomp * Maybe this will fix the thests * Grants action container to performer as well * Wait that makes no sense, removing that * fixes mind action grant logic * Changes ent check back to netent check * Reverts unintended container changes * fix medhud bounds with 64x64 inhands (#24102) * aspid update (#24103) * bagel update (#24104) * bagel update * argh * box update (#24105) * centcomm update (#24107) centcomm * cluster update (#24108) * fland update (#24109) * gemini update (#24110) * marathon update (#24111) * marathon update * light * meta update (#24112) * omega update (#24113) * packed update (#24114) * reach update (#24115) * Fixes the eye protection requirement of welding tools being inverted (#24106) After a power outage and a whole hour of fixing a broken .git: fixes welding tools having inverted toggle states for eye protection requirements * Automatic changelog update * Reduces stimpack price to 4 TC (#24117) done * Automatic changelog update * Readd core cargo shuttle (#24118) add * Update Core (#24121) add * Construction Blast door (#24050) * construction blast door * fix * price * fix2 * hem * xif * Static * Automatic changelog update * Tropico pet added to thief objective pool (#24119) * git it's the same stop gaslighting yourself * tropico added to thief objective pool * fix damage type for arachnid melee (#24137) fix damage type * fix cryo bed dragging (#24125) * atlas cryosleep (#24126) * atlas cryosleep * invalid hunter --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * saltern cryosleep (#24127) Co-authored-by: deltanedas <@deltanedas:kde.org> * Flatcaps (#24134) * Brown and Grey flatcaps added What it says on the tin is what it is * Fixed Copyright Jazz, oops What it says on the tin * Cossack Visual Change (#24129) c * more objective logging + maybe fix the no objective bug (#24139) * more objective log * remove hijack from group!!!! --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Reinforced glass reacting fix (#24135) * takeitouttakeitout * Delete error.glsl --------- Co-authored-by: Nemanja <[email protected]> * Automatic changelog update * fix cryosleepers deleting the station (#24143) * fix cryogenic units deleting the station * ship it * terminal update (#24145) * Cleanup Medicine Descriptions (#24141) Medicine Cleanup TIme * medal case sprite (#24147) medal case no longer cigar case lmao * Explosion log fix fix (#24136) * Reaction and Explosion admin log coordinates * Remove extraneous whitespace * Automatic changelog update * fix radiators leaking heat into atmos blocked tiles (#24124) * fix radiators leaking heat into atmos blocked tiles * Fix the fix Pointyhat to: emogarbage * Remove unused imports --------- Co-authored-by: Kevin Zheng <[email protected]> * Don't throw on player spawn for playtime failure (#24148) Still gets logged but won't abort the entire startup process. * Update Core (#24149) ya * Fix flare shell not applying firestacks and makes it embed (#23648) * Fix flare gun not igniting and small firestack increase. * Flare shells now embed * Automatic changelog update * Fix some closets being not deconstructable (#23054) * sss * price change * Resprite buckets (#23866) * add * fix * tweak * bucket * buckt * bucket'd * buckt * bottm roundinger * Automatic changelog update * Fix missing [NetSerializable] in SimplePredictReconcileTest (#24161) This didn't cause any issues because NetSerializer wasn't used in integration tests... until space-wizards/RobustToolbox#4838. * qol tweak: More context about how to access traitor uplink in character menu (#24163) Update preset-traitor.ftl * Fix DragDropHelper not respecting the control.drag_dead_zone cvar (#24166) Fix regression with the drag_dead_zone cvar not being used * try and purify cryosleeper code (#24165) * Hauling shuttle wreck (#24152) add * Remove prototypes locale (#24159) * bagel update (#24168) * Follow command and ahelp menu follow (#24142) * Command & ahelp rename * Reviews * remove tpto * Automatic changelog update * Add a way for bulk abstracting prototypes (#24140) * Ignored Prototypes * respath it * add multi-file support * box update (#24176) * meta update (#24177) * emergency box grid name (#24178) emergency box * Fix water gun and spray nozzle projectile collision (#24175) fix water gun and spray nozzle collision * Automatic changelog update * Add 6 new small salvage wrecks (#24179) * add * updat * Executions (#24150) * Execution (you monster) not done * woops * more stuff * Melee executions * Prevent executing those who can interact * Better checks for if you can execute * Scale the execution time of a knife with its attack speed * Translations for fucking up an execution * rename some functions * Properly scale execution speed of melee weapons * Fix checks in CanExecuteWithAny * Allow executing yourself (funny) * More versatile localisation * Suicide with guns * Popups for successful gun executions * whoops * Stop flare guns crashing the game on executions * Various tweaks * Remove some old usings * Pacifists can no longer execute * Remove unnecessary check * Use CanShoot in gunsystem * Capitalisation in ftl string * Fix melee executions not playing a sound * localisation tweaks * Add Mothroach Burger (#24156) * Add Mothroach Burger * append copyright * fix whitespace and metajson ordering * Automatic changelog update * Move rotting stages and examine to shared (#24183) * Robohands glove sprite (#24182) add * Automatic changelog update * WelderRefinable light tubes bulbs and broken bottle (#24184) s * Remove obsolete ftl call (#24187) Nothing burger * Grindable ores (#24185) add * Automatic changelog update * Reagent grinder jittering (#24190) * Reagent grinder jittering * Fix jittering for offset sprites * Change default lights on devmap to non-LED ones (#24192) * Automatic changelog update * bagel update (#24191) * bagel update * ok a lot more * Xenoarch scanning time halved (#24188) * SALVATION * Update ArtifactAnalyzerComponent.cs * Update artifact_analyzer.yml * Significantly less annoying eating sounds (#24195) * Automatic changelog update * Mouse sprite movement states (#24202) * Add limited-reagent dispensers (#23907) * Add limited-reagent dispensers * Add empty versions for all dispensers * Fix lint * Set initial window size so all buttons are visible * Simplify logic, add parenthesis * Use localized name for initial labels * Adjust button style * Avoid touching items before MapInit * Remove pre-labeling * Reduce diff * Clean up YAML * Fix test * Really fix test * Document * Adjust based on review * Add labels for obnoxiously long bottles --------- Co-authored-by: AWF <[email protected]> * Automatic changelog update * localize shuttle timer eta etd (#24204) * Chicken sprite movement states (#24205) * Fix comp.Owner (#24206) * Repairable shuttles (#24193) * fixable shuttle * nukie not repairable * fix * Automatic changelog update * Do not log missing components in OpenableSystem (#24208) Do not log missing components * fix flippo not igniting plasma (#24207) Add welder component to FlippoLighter * Automatic changelog update * Use old reagent dispenser beaker slot ID (#24209) Change the slot ID back to what it was to keep old map saves with an item in the slot loading correctly. This also fixes the "You can't put this in the dispenser!" message not appearing when inserting an item without FitsInDispenserComponent because the whitelisted slot name wasn't changed. * reach update (#24211) * Fix error when starting a DoAfter while handling one on the same entity (#24218) * Fix error when starting a DoAfter while handling one on the same entity * Reuse array * Golden honker glow (#24230) add * Paramedic void suit is now a soft suit. (#24229) add * Carrots now properly contain Oculine (#24228) * carrot * add * quantity * Automatic changelog update * Automatic changelog update * Add pacifism description and clean up traits a little (#24216) add * make terminator immune to rev and zombie (#24239) Co-authored-by: deltanedas <@deltanedas:kde.org> * Fix solution corruption when grinding a stack of items (#24242) Fix corruption when grinding a stack of items * Add fill visuals and inhand sprites to water bottle (#24240) * Add fill visuals and inhand sprites to water bottle * adjust sprite * Fix entity menu grouping and sorting (#24243) * Group entity menu by the displayed name instead of by the prototype * Sort entity menu by the displayed name (with label) in current culture * Automatic changelog update * Wrap objective briefing text (#24244) * Fix drink examine text (#24241) * More sprite movement states (#24237) * More sprite movement states * what * Finally fix cryostorage duping (#24251) * Automatic changelog update * Spawn guidebooks on random bookshelves (#24036) * Automatic changelog update * fix gas canister names (#24252) fix canister names * Add trade stations (#23863) * puters * Start on fulfillment * weh * Smol update * FTL sound fixes or smth iunno * Add consoles * More tweaks * Make it unanchorable * final wehs * weh * Fix 1 test * Shrimply bump the distance * cat * Automatic changelog update * Update submodule to 207.0.0 (#24255) * Title2 (#24254) * title2 * Update lobby.yml * Update attributions.yml * real * Automatic changelog update * Botany guide chemicals (#24194) * Adjust produce (#24220) * Fix salvage wreck names (#24256) add * Rework wheelchairbound (#24173) * Rework wheelchairbound Fixes the save/load bug and fixes it being a singleton. * weh * Make super bite burger easier to craft (#24231) * add * needs space for salt * Change the station map dot color to cyan (#24082) Change the station map tracking dot color to cyan Co-authored-by: iacore <[email protected]> * Restart votes check player count and ghost levels (#23453) * Restarts have max player count * Now counts ingame ghosts to determine if restart can be called * consistant cvar name * Added a player count with state conditional * Run fixgridatmos on trading outpost (#24264) * Automatic changelog update * Add ability to put spesos into cargo console (#24263) I thought we had it already but maybe it was an unfinished pr or something. * Automatic changelog update * Added defib to Brigmed on Box (#24269) * Moved Gemini's Brigmed defib to the inside (#24273) * Added defib to Brigmed on Origin (#24272) * Added defib to Brigmed on Meta (#24271) * Clear cargo orders on approval (#24278) * Update Trading Outpost (#24281) * add * yes * Fix gun bolt crash (#24283) Deleting non-predicted entities moment. * Automatic changelog update * Improve light tube sprites (#24270) * fix * blocky * glowier * darker * Actually fix carrot oculine this time (#24290) SEEDS MAN * Destruction & impact sound rework pass 1 (#24282) * Various sounds ported * Replace wall_bonk.ogg * Metal/metalglass break sound pass * Replace metalbreak.ogg * Replace woodhit * Replcae tap.ogg n some smack uses * Fix lint * Replace bang.ogg and some instances of hit_kick.ogg * couple more * fix wood sound * i may be stupid * le attributing * bro what * standardize more destruction sounds * fix melee hit sound cutting off * window threshold sounds and remove `destroySound` it literally doesnt exist * Automatic changelog update * Can emag artifact crusher (#23957) * initial commit * made it emaggable * removed OnAttemptEmagEvent * moved emagging to shared * added local file to git * Automatic changelog update * Adds more grindables (#24267) * Adds more grindables * fuc * A * Fix reagents obtained from grinding iron ore. (#24215) add * Mustard, ketchup and mayonnaise now tastes distinct (#24297) add * Update Trade Station (#24295) add * Update Core (#24294) add * Update Rod and Transit evacuation shuttles (#24296) add * Lathe Categories (#24247) * Lathe Categories * serilog my beloathed * Automatic changelog update * Unrevivable trait (#24226) * unrevivable trait + remove unclonable remnants * cleanup * change to hascomp * Automatic changelog update * Toolboxes (#24305) * Added animations for opening toolboxes * Fix cow toolbox * Automatic changelog update * Revert "Adds more grindables (#24267)" (#24311) This reverts commit 16a1f2f. * Rebalance of Lobbying bundle (#24303) * Rebalance of Lobbying bundle - More money, mickey (5000 -> 30000) - Added trader`s rubberstump for high iq players - Phone to call upper managment - Some fancy and absolutely unsuspicious clothings - Patriotic Flag for the most valuable lobist of Syndicate * Thief problem fix Thief now have have separate lobbying bundle, now it calls bribing bundle * Fixing Money count, suffix * Hi Fixing money * Automatic changelog update * Prevent EntityStorages from being opened while inside another container (#24253) * Prevent EntityStorages from being opened while inside a mech. * compressed into few lines * unneeded line * Popup client --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Add netserializable to test doafter (#24313) Might fix the test failure * Fixes round restart audio clipping (#24044) * Fix round end audio clipping * weh --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Fix cargo product groups (#24212) * Cargo fixes (#24318) Wrong button. * Change what items can be fultoned while stopping anchored items from fultoning (#20628) * Check and restrict players from fultoning their equipped items * Changed fulton whitelist to items and anchorables * Stop from anchored items being fultoned * Moved containermanager check to CanFulton function * review --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Make crushers not craftable/researchable (#24319) * nomorecrushersci * nocomment * Automatic changelog update * Fix some test warnings (#24324) Extracted from smug's pr. * Fix drag-drop buckle sound playing twice (#24321) Buckle refactor somedayTM. * Automatic changelog update * Beacon localization (#24138) * localize beacons * No not like that * Tesla beacons were already depreciated, time to give the reaper their due * Entity name fallback * The real treasure was the far easier solution we missed along the way * weh * Shared mapinit * fix RT version * a single line break * fix scram implant uplink desc (#24336) fix * update locale --------- Co-authored-by: Arendian <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: Ilya246 <[email protected]> Co-authored-by: Vasilis <[email protected]> Co-authored-by: Aexxie <[email protected]> Co-authored-by: SlamBamActionman <[email protected]> Co-authored-by: Varen <[email protected]> Co-authored-by: degradka <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tayrtahn <[email protected]> Co-authored-by: deathride58 <[email protected]> Co-authored-by: 21Melkuu <[email protected]> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: Trevor Day <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: Morb <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Dakamakat <[email protected]> Co-authored-by: AJCM-git <[email protected]> Co-authored-by: Whisper <[email protected]> Co-authored-by: Magnus Larsen <[email protected]> Co-authored-by: Kot <[email protected]> Co-authored-by: Alekshhh <[email protected]> Co-authored-by: Psychpsyo <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: Nairod <[email protected]> Co-authored-by: Skye <[email protected]> Co-authored-by: Flareguy <[email protected]> Co-authored-by: keronshb <[email protected]> Co-authored-by: Boaz1111 <[email protected]> Co-authored-by: Ubaser <[email protected]> Co-authored-by: Nim <[email protected]> Co-authored-by: reverie collection <[email protected]> Co-authored-by: CrigCrag <[email protected]> Co-authored-by: Hanz <[email protected]> Co-authored-by: Kevin Zheng <[email protected]> Co-authored-by: Arkanic <[email protected]> Co-authored-by: LankLTE <[email protected]> Co-authored-by: Veritius <[email protected]> Co-authored-by: TurboTrackerss14 <[email protected]> Co-authored-by: Kara <[email protected]> Co-authored-by: AWF <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Volodius <[email protected]> Co-authored-by: 0x6273 <[email protected]> Co-authored-by: lapatison <[email protected]> Co-authored-by: IlyaElDunaev <[email protected]> Co-authored-by: iacore <[email protected]> Co-authored-by: iacore <[email protected]> Co-authored-by: Repo <[email protected]> Co-authored-by: Krunklehorn <[email protected]> Co-authored-by: SpeltIncorrectyl <[email protected]> Co-authored-by: Scribbles0 <[email protected]> Co-authored-by: Drayff <[email protected]> Co-authored-by: Agoichi <[email protected]> Co-authored-by: Hannah Giovanna Dawson <[email protected]> Co-authored-by: Kacper Urbańczyk <[email protected]> Co-authored-by: Alzore <[email protected]>
k3yw
added a commit
to k3yw/fish-station-14-abandoned
that referenced
this pull request
Jan 25, 2024
* Automatic changelog update * Action, Action Container, and Action Upgrade changes (#24005) * Added TransferActionWithNewAttached and TransferAllActionsWithNewAttached and OnActionAdded event method to ActionContainerSystem. These are needed where the action needs to have a different attached entity for usage. Fixed a bug with not being able to upgrade actions between levels. Added a way to grant and remove a singular action. * adds an action container component to mind on action added to fix tests * Swaps trycomp for hascomp * Maybe this will fix the thests * Grants action container to performer as well * Wait that makes no sense, removing that * fixes mind action grant logic * Changes ent check back to netent check * Reverts unintended container changes * fix medhud bounds with 64x64 inhands (#24102) * aspid update (#24103) * bagel update (#24104) * bagel update * argh * box update (#24105) * centcomm update (#24107) centcomm * cluster update (#24108) * fland update (#24109) * gemini update (#24110) * marathon update (#24111) * marathon update * light * meta update (#24112) * omega update (#24113) * packed update (#24114) * reach update (#24115) * Fixes the eye protection requirement of welding tools being inverted (#24106) After a power outage and a whole hour of fixing a broken .git: fixes welding tools having inverted toggle states for eye protection requirements * Automatic changelog update * Reduces stimpack price to 4 TC (#24117) done * Automatic changelog update * Readd core cargo shuttle (#24118) add * Update Core (#24121) add * Construction Blast door (#24050) * construction blast door * fix * price * fix2 * hem * xif * Static * Automatic changelog update * Tropico pet added to thief objective pool (#24119) * git it's the same stop gaslighting yourself * tropico added to thief objective pool * Outpost Update (space-syndicate#1766) * Translate Upstream space-syndicate#1764 (space-syndicate#1765) * fix damage type for arachnid melee (#24137) fix damage type * fix cryo bed dragging (#24125) * atlas cryosleep (#24126) * atlas cryosleep * invalid hunter --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * saltern cryosleep (#24127) Co-authored-by: deltanedas <@deltanedas:kde.org> * Flatcaps (#24134) * Brown and Grey flatcaps added What it says on the tin is what it is * Fixed Copyright Jazz, oops What it says on the tin * Cossack Visual Change (#24129) c * more objective logging + maybe fix the no objective bug (#24139) * more objective log * remove hijack from group!!!! --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Reinforced glass reacting fix (#24135) * takeitouttakeitout * Delete error.glsl --------- Co-authored-by: Nemanja <[email protected]> * Automatic changelog update * fix cryosleepers deleting the station (#24143) * fix cryogenic units deleting the station * ship it * terminal update (#24145) * Cleanup Medicine Descriptions (#24141) Medicine Cleanup TIme * medal case sprite (#24147) medal case no longer cigar case lmao * Explosion log fix fix (#24136) * Reaction and Explosion admin log coordinates * Remove extraneous whitespace * Automatic changelog update * fix radiators leaking heat into atmos blocked tiles (#24124) * fix radiators leaking heat into atmos blocked tiles * Fix the fix Pointyhat to: emogarbage * Remove unused imports --------- Co-authored-by: Kevin Zheng <[email protected]> * Don't throw on player spawn for playtime failure (#24148) Still gets logged but won't abort the entire startup process. * Update Core (#24149) ya * Fix flare shell not applying firestacks and makes it embed (#23648) * Fix flare gun not igniting and small firestack increase. * Flare shells now embed * Automatic changelog update * Fix some closets being not deconstructable (#23054) * sss * price change * Forensics guide addition (space-syndicate#1698) * Resprite buckets (#23866) * add * fix * tweak * bucket * buckt * bucket'd * buckt * bottm roundinger * Automatic changelog update * Translation fixes (space-syndicate#1768) Co-authored-by: faint <[email protected]> * Fix missing [NetSerializable] in SimplePredictReconcileTest (#24161) This didn't cause any issues because NetSerializer wasn't used in integration tests... until space-wizards/RobustToolbox#4838. * qol tweak: More context about how to access traitor uplink in character menu (#24163) Update preset-traitor.ftl * Fix DragDropHelper not respecting the control.drag_dead_zone cvar (#24166) Fix regression with the drag_dead_zone cvar not being used * try and purify cryosleeper code (#24165) * Hauling shuttle wreck (#24152) add * Remove prototypes locale (#24159) * bagel update (#24168) * Follow command and ahelp menu follow (#24142) * Command & ahelp rename * Reviews * remove tpto * Automatic changelog update * Defusal & cargo general guidebooks translate (space-syndicate#1761) Co-authored-by: faint <[email protected]> * Nukies guidebook translate (space-syndicate#1732) Co-authored-by: faint <[email protected]> * Make mindshielded not pacified at round end (space-syndicate#1708) * Add a way for bulk abstracting prototypes (#24140) * Ignored Prototypes * respath it * add multi-file support * box update (#24176) * meta update (#24177) * emergency box grid name (#24178) emergency box * Fix water gun and spray nozzle projectile collision (#24175) fix water gun and spray nozzle collision * Automatic changelog update * Add 6 new small salvage wrecks (#24179) * add * updat * Executions (#24150) * Execution (you monster) not done * woops * more stuff * Melee executions * Prevent executing those who can interact * Better checks for if you can execute * Scale the execution time of a knife with its attack speed * Translations for fucking up an execution * rename some functions * Properly scale execution speed of melee weapons * Fix checks in CanExecuteWithAny * Allow executing yourself (funny) * More versatile localisation * Suicide with guns * Popups for successful gun executions * whoops * Stop flare guns crashing the game on executions * Various tweaks * Remove some old usings * Pacifists can no longer execute * Remove unnecessary check * Use CanShoot in gunsystem * Capitalisation in ftl string * Fix melee executions not playing a sound * localisation tweaks * Add Mothroach Burger (#24156) * Add Mothroach Burger * append copyright * fix whitespace and metajson ordering * Automatic changelog update * Move rotting stages and examine to shared (#24183) * Robohands glove sprite (#24182) add * Automatic changelog update * WelderRefinable light tubes bulbs and broken bottle (#24184) s * Remove obsolete ftl call (#24187) Nothing burger * Grindable ores (#24185) add * Automatic changelog update * Reagent grinder jittering (#24190) * Reagent grinder jittering * Fix jittering for offset sprites * Change default lights on devmap to non-LED ones (#24192) * Automatic changelog update * bagel update (#24191) * bagel update * ok a lot more * Xenoarch scanning time halved (#24188) * SALVATION * Update ArtifactAnalyzerComponent.cs * Update artifact_analyzer.yml * Significantly less annoying eating sounds (#24195) * Automatic changelog update * Resprite BrickTile decals (space-syndicate#1747) * Corpos DeLocale (space-syndicate#1741) * [Resprite] Swapper (space-syndicate#1746) * Translate vulpkanin (space-syndicate#1771) * Fix bricktile meta.json version * Revert suit storage & light tube sprites (space-syndicate#1770) * [HotFix] Avrite (space-syndicate#1773) * Mouse sprite movement states (#24202) * Add limited-reagent dispensers (#23907) * Add limited-reagent dispensers * Add empty versions for all dispensers * Fix lint * Set initial window size so all buttons are visible * Simplify logic, add parenthesis * Use localized name for initial labels * Adjust button style * Avoid touching items before MapInit * Remove pre-labeling * Reduce diff * Clean up YAML * Fix test * Really fix test * Document * Adjust based on review * Add labels for obnoxiously long bottles --------- Co-authored-by: AWF <[email protected]> * Automatic changelog update * localize shuttle timer eta etd (#24204) * Chicken sprite movement states (#24205) * Update locale * Fix comp.Owner (#24206) * Repairable shuttles (#24193) * fixable shuttle * nukie not repairable * fix * Automatic changelog update * Do not log missing components in OpenableSystem (#24208) Do not log missing components * fix flippo not igniting plasma (#24207) Add welder component to FlippoLighter * Automatic changelog update * Use old reagent dispenser beaker slot ID (#24209) Change the slot ID back to what it was to keep old map saves with an item in the slot loading correctly. This also fixes the "You can't put this in the dispenser!" message not appearing when inserting an item without FitsInDispenserComponent because the whitelisted slot name wasn't changed. * reach update (#24211) * Fix error when starting a DoAfter while handling one on the same entity (#24218) * Fix error when starting a DoAfter while handling one on the same entity * Reuse array * Update silly (space-syndicate#1778) * Update spectrum (space-syndicate#1777) * Translate Upstream space-syndicate#1775 (space-syndicate#1776) Co-authored-by: lzk <[email protected]> * Fix tts settings (space-syndicate#1774) * Golden honker glow (#24230) add * Paramedic void suit is now a soft suit. (#24229) add * Carrots now properly contain Oculine (#24228) * carrot * add * quantity * Automatic changelog update * Automatic changelog update * Add pacifism description and clean up traits a little (#24216) add * [Maps] Astra update (space-syndicate#1782) Co-authored-by: poeMota <[email protected]> * Outpost update (space-syndicate#1780) * [MapUpdate] Avrite (space-syndicate#1781) * make terminator immune to rev and zombie (#24239) Co-authored-by: deltanedas <@deltanedas:kde.org> * Fix solution corruption when grinding a stack of items (#24242) Fix corruption when grinding a stack of items * Add fill visuals and inhand sprites to water bottle (#24240) * Add fill visuals and inhand sprites to water bottle * adjust sprite * Fix entity menu grouping and sorting (#24243) * Group entity menu by the displayed name instead of by the prototype * Sort entity menu by the displayed name (with label) in current culture * Automatic changelog update * Wrap objective briefing text (#24244) * Fix drink examine text (#24241) * More sprite movement states (#24237) * More sprite movement states * what * Finally fix cryostorage duping (#24251) * Automatic changelog update * Spawn guidebooks on random bookshelves (#24036) * Automatic changelog update * fix gas canister names (#24252) fix canister names * Add trade stations (#23863) * puters * Start on fulfillment * weh * Smol update * FTL sound fixes or smth iunno * Add consoles * More tweaks * Make it unanchorable * final wehs * weh * Fix 1 test * Shrimply bump the distance * cat * Automatic changelog update * Update submodule to 207.0.0 (#24255) * Title2 (#24254) * title2 * Update lobby.yml * Update attributions.yml * real * Automatic changelog update * Botany guide chemicals (#24194) * Adjust produce (#24220) * Fix salvage wreck names (#24256) add * Rework wheelchairbound (#24173) * Rework wheelchairbound Fixes the save/load bug and fixes it being a singleton. * weh * Make super bite burger easier to craft (#24231) * add * needs space for salt * Change the station map dot color to cyan (#24082) Change the station map tracking dot color to cyan Co-authored-by: iacore <[email protected]> * Restart votes check player count and ghost levels (#23453) * Restarts have max player count * Now counts ingame ghosts to determine if restart can be called * consistant cvar name * Added a player count with state conditional * Run fixgridatmos on trading outpost (#24264) * Automatic changelog update * Add ability to put spesos into cargo console (#24263) I thought we had it already but maybe it was an unfinished pr or something. * Automatic changelog update * Added defib to Brigmed on Box (#24269) * Moved Gemini's Brigmed defib to the inside (#24273) * Added defib to Brigmed on Origin (#24272) * Added defib to Brigmed on Meta (#24271) * Clear cargo orders on approval (#24278) * Update Trading Outpost (#24281) * add * yes * Fix gun bolt crash (#24283) Deleting non-predicted entities moment. * Automatic changelog update * Improve light tube sprites (#24270) * fix * blocky * glowier * darker * Actually fix carrot oculine this time (#24290) SEEDS MAN * Destruction & impact sound rework pass 1 (#24282) * Various sounds ported * Replace wall_bonk.ogg * Metal/metalglass break sound pass * Replace metalbreak.ogg * Replace woodhit * Replcae tap.ogg n some smack uses * Fix lint * Replace bang.ogg and some instances of hit_kick.ogg * couple more * fix wood sound * i may be stupid * le attributing * bro what * standardize more destruction sounds * fix melee hit sound cutting off * window threshold sounds and remove `destroySound` it literally doesnt exist * Automatic changelog update * Can emag artifact crusher (#23957) * initial commit * made it emaggable * removed OnAttemptEmagEvent * moved emagging to shared * added local file to git * Automatic changelog update * Adds more grindables (#24267) * Adds more grindables * fuc * A * Fix reagents obtained from grinding iron ore. (#24215) add * Mustard, ketchup and mayonnaise now tastes distinct (#24297) add * Gate Returns + Outpost hotfix (space-syndicate#1784) * Update Trade Station (#24295) add * Update Core (#24294) add * Update Rod and Transit evacuation shuttles (#24296) add * Lathe Categories (#24247) * Lathe Categories * serilog my beloathed * Automatic changelog update * Unrevivable trait (#24226) * unrevivable trait + remove unclonable remnants * cleanup * change to hascomp * Automatic changelog update * Toolboxes (#24305) * Added animations for opening toolboxes * Fix cow toolbox * Automatic changelog update * Revert "Adds more grindables (#24267)" (#24311) This reverts commit 16a1f2f. * Rebalance of Lobbying bundle (#24303) * Rebalance of Lobbying bundle - More money, mickey (5000 -> 30000) - Added trader`s rubberstump for high iq players - Phone to call upper managment - Some fancy and absolutely unsuspicious clothings - Patriotic Flag for the most valuable lobist of Syndicate * Thief problem fix Thief now have have separate lobbying bundle, now it calls bribing bundle * Fixing Money count, suffix * Hi Fixing money * Automatic changelog update * Prevent EntityStorages from being opened while inside another container (#24253) * Prevent EntityStorages from being opened while inside a mech. * compressed into few lines * unneeded line * Popup client --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Add netserializable to test doafter (#24313) Might fix the test failure * Fixes round restart audio clipping (#24044) * Fix round end audio clipping * weh --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Fix cargo product groups (#24212) * Cargo fixes (#24318) Wrong button. * Change what items can be fultoned while stopping anchored items from fultoning (#20628) * Check and restrict players from fultoning their equipped items * Changed fulton whitelist to items and anchorables * Stop from anchored items being fultoned * Moved containermanager check to CanFulton function * review --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Make crushers not craftable/researchable (#24319) * nomorecrushersci * nocomment * Automatic changelog update * Fix some test warnings (#24324) Extracted from smug's pr. * Fix drag-drop buckle sound playing twice (#24321) Buckle refactor somedayTM. * Automatic changelog update * Beacon localization (#24138) * localize beacons * No not like that * Tesla beacons were already depreciated, time to give the reaper their due * Entity name fallback * The real treasure was the far easier solution we missed along the way * weh * Shared mapinit * fix RT version * a single line break * fix scram implant uplink desc (#24336) fix * Add admin log messages for gamerule addition and end (#24092) * Add admin log messages for gamerule addition and end * Use EventRan end EventStopped LogTypes instead of new GameRule logtype * Apply suggestions from code review --------- Co-authored-by: Chief-Engineer <[email protected]> * Automatic changelog update * Fix issue where round could reset all job priorities to high (#24340) * Update job priorities when job requirements are getting updated * Sort jobs by weight and then by the name * Sort departments too * Add snake kebab (#24341) * add snake kebab * fix sprite * just meat * Cerberus Wideswing (#24328) arf * Buff potassium availability from bananas (#24257) * banana * yes * Automatic changelog update * Remove ability to start pulling while inside a container (#24235) * why was this even possible * what coding at 6am does to a mf * Update locale * Fix locale * Update Credits (#24352) Co-authored-by: PJBot <[email protected]> * Allow chemical-fueled generators to use multiple reagents (#24258) multi-reagent generators * Use MetalBreak collection * The glowing forest anomaly (#24351) * sans * Papyrus * add to game * tweak stick * fixes * Update Resources/Prototypes/Entities/Objects/Misc/kudzu.yml Co-authored-by: Kara <[email protected]> * Update Resources/Prototypes/Entities/Structures/Specific/Anomaly/anomalies.yml Co-authored-by: Kara <[email protected]> --------- Co-authored-by: Kara <[email protected]> * Automatic changelog update * Update locale * Cancel CanBuckle before popup for foldable items (#24358) * Cancel CanBuckle before popup for foldable items * Moved to FoldableSystem * Content grid merging (#22448) Mainly fixing thruster bugs * Make radarcontrol use approx grids (#24360) * Fix keyboard sounds not playing when opening a computer UI (#24348) Fix keyboard sounds not playing on UI open * Update submodule to 207.1.0 (#24361) * Star Wars 14: Shuttle weapon update (#23644) * setup codebase * make auto-fire, but its broken * collider problem * fix rate, add toggle port * add laser * power cages * ginormous cells * fix inhand * add pirate cannon * salvage gun * functional Nuke cannon * rewrite to standart grenade * fix naming, add emp sprite * grenade cartridge * thruster fix * nuke cannon * audio + visual polish * balance tweak * tweaks * laser balance tweak: new Electronic damage modifier set, reduce structural cannon damage * resprite energy cages, start implementing in game * fix cage recharger craft * add small laser gun * fix colliders * add lasers and ptk to research and crafting * finish implementing weapon to rnd and sec * some fixes * splitted grenades and cannon balls * integrate new cannon balls * tweaks stick * move circuits to sectechfab, fix * fix? * add ability to E shoot, without signals * fix! * fix?!?! and naming tweak * go! * Lank fix * oh * mornings don't start with coffee. * the morning starts with bug fixes. * fucking bugs! * finally * it is now possible to craft projectiles separately from cartridges * +2 fix * refactor * piu * More weight * add AutoShootGunComponent * move autoshoot to partial * SetEnabled() * some fixes * remove CanShootWithoutUser field * remove null-checks ToCoordinates from AttemptShoot() * war without reason * return to home * ? * forgot remove it * review * Fix formatting and update path --------- Co-authored-by: metalgearsloth <[email protected]> * Add chat.max_announcement_length cvar (#23571) * Add announce message length to UI and make a cvar for it * Update comm console server-side trim to use the cvar * Rely on the new OnTextChanged event Because OnKeyBindUp only works for keys that have binds * Add a similar indicator to nukies' war declaration UI * Remove message length indicators for now cuz it requires the engine update * Rename cvar slightly * Refactor duplicated code to a helper method * Remove message trimming from *Window class as it's better to live in the BoundUserInterface where the other message handling happens * Rename to chat.max_announcement_length * PA control box part detection fix (#24356) * * Fixed rounding errors when the PA control box was checking for parts, sometimes leading to the obscure "port/starboard emitters are not detected". * Auto-rotated the PA control box toward the fuel box when checking for parts * Swapped the wired/completed state sprites for the PA control box as it appears they were inverted * Update Content.Server/ParticleAccelerator/EntitySystems/ParticleAcceleratorSystem.Parts.cs --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Flora anom hotfix (#24364) * fix * less entities * ф * Fix security camera sprite when viewed at an angle (#24357) The 8-directions is a vestige of /tg/station, where the extra directions were used to place cameras on the left or right half of the wall. Setting it to 1 directions (sic) allows the game engine to rotate the sprite for us, which is fine as the art currently has no perspective. * Bunch of revolver fixes (#19649) * Bunch of revolver fixes Some stuff wasn't working with prediction so this should fix all of it. * a * fix weh * Also usedelay * Automatic changelog update * Fix dock highlighting (#24369) Nentity casualty * Automatic changelog update * Locale fixes (space-syndicate#1785) * Translate Upstream space-syndicate#1787 (space-syndicate#1790) * Update locale * Hotfix chemical use division by zero * Largo sound & hearts on interact (space-syndicate#1794) * Disable record of TTS in replays * Translate Upstream space-syndicate#1792 (space-syndicate#1793) Co-authored-by: lzk <[email protected]> * Fix stray pixel on poster 22 legit (space-syndicate#1795) * [Maps] Lil delta update (space-syndicate#1791) Co-authored-by: poeMota <[email protected]> * Fix reptilian digi (space-syndicate#1796) * module sync * module sync * submodule netserializer sync * Карты, обнова и новое лого --------- Co-authored-by: PJBot <[email protected]> Co-authored-by: keronshb <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: deathride58 <[email protected]> Co-authored-by: Boaz1111 <[email protected]> Co-authored-by: Ubaser <[email protected]> Co-authored-by: Nim <[email protected]> Co-authored-by: reverie collection <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: lapatison <[email protected]> Co-authored-by: CrigCrag <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: Hanz <[email protected]> Co-authored-by: Alekshhh <[email protected]> Co-authored-by: Skye <[email protected]> Co-authored-by: Trevor Day <[email protected]> Co-authored-by: Kevin Zheng <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Arendian <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: faint <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Arkanic <[email protected]> Co-authored-by: Kot <[email protected]> Co-authored-by: LankLTE <[email protected]> Co-authored-by: Veritius <[email protected]> Co-authored-by: TurboTrackerss14 <[email protected]> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: Kara <[email protected]> Co-authored-by: Ko4ergaPunk <[email protected]> Co-authored-by: KREKS <[email protected]> Co-authored-by: Morb0 <[email protected]> Co-authored-by: Syxapik <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: AWF <[email protected]> Co-authored-by: Volodius <[email protected]> Co-authored-by: 0x6273 <[email protected]> Co-authored-by: CrazyCat2048 <[email protected]> Co-authored-by: poeMota <[email protected]> Co-authored-by: poeMota <[email protected]> Co-authored-by: Tayrtahn <[email protected]> Co-authored-by: IlyaElDunaev <[email protected]> Co-authored-by: iacore <[email protected]> Co-authored-by: iacore <[email protected]> Co-authored-by: Repo <[email protected]> Co-authored-by: Krunklehorn <[email protected]> Co-authored-by: SpeltIncorrectyl <[email protected]> Co-authored-by: Flareguy <[email protected]> Co-authored-by: Scribbles0 <[email protected]> Co-authored-by: Drayff <[email protected]> Co-authored-by: Agoichi <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Hannah Giovanna Dawson <[email protected]> Co-authored-by: Kacper Urbańczyk <[email protected]> Co-authored-by: Alzore <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: Ilya246 <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: GreyMario <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Menshin <[email protected]> Co-authored-by: Magnus Larsen <[email protected]> Co-authored-by: k3ywarrior <[email protected]>
DebugOk
pushed a commit
to DebugOk/Delta-v
that referenced
this pull request
Jan 27, 2024
This didn't cause any issues because NetSerializer wasn't used in integration tests... until space-wizards/RobustToolbox#4838. (cherry picked from commit 45136ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests don't use Lidgren to connect client and send, instead they just use some in-process channels to communicate. Because of this, the original implementation of net messages directly passed the net message instances between client and server instances. This caused issues whenever content would mutate data in a NetMessage after it "passed through".
Now we run the messages through WriteToBuffer() and ReadFromBuffer() so they pass through binary serialization. This means there's no more implicit sharing of the objects.
Note that this requires some trickery: Lidgren's message types have internal constructors. Really ideally we'd change the engine to make this more testable... but that's a content breaking change. Instead I just added InternalsVisibleTo to Lidgren so we can mess with it. We maintain the library ourselves anyways I can do what I want.
Fixes #4836