-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide PII from admins who lack that permission #70
Conversation
I forgot about the ban creation page, but I'm not sure how I could take care of that without also breaking the grab info from latest connection function |
Dont make a constant use the identity system to just check if they are in the role PII, it creates roles based on the flag enum |
I'm not sure I understand what you mean, is it just bad to do this or is it not supposed to work? |
I have no idea, ima jsut let pjb reveiw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good so far.
Closes #66.
I hope I got all instances, this makes it so you're unable to see PII of any user, or search for it if you don't have the permission.
In the cases where I could remove it without affecting the layout of the page, I did. Where I couldn't, I replaced the text with "Hidden". I'm ready for this to be torn to shreds in a review, as I wouldn't be surprised if I made a silly mistake.
The ban creation page was also updated to remove the buttons, and replace them with checkboxes instead