Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide PII from admins who lack that permission #70

Merged
merged 10 commits into from
Jun 21, 2024

Conversation

NullWanderer
Copy link
Contributor

@NullWanderer NullWanderer commented Jun 10, 2024

Closes #66.

I hope I got all instances, this makes it so you're unable to see PII of any user, or search for it if you don't have the permission.

In the cases where I could remove it without affecting the layout of the page, I did. Where I couldn't, I replaced the text with "Hidden". I'm ready for this to be torn to shreds in a review, as I wouldn't be surprised if I made a silly mistake.

The ban creation page was also updated to remove the buttons, and replace them with checkboxes instead

image
image
image

@NullWanderer
Copy link
Contributor Author

I forgot about the ban creation page, but I'm not sure how I could take care of that without also breaking the grab info from latest connection function

@Geekyhobo
Copy link
Contributor

Dont make a constant use the identity system to just check if they are in the role PII, it creates roles based on the flag enum

@NullWanderer
Copy link
Contributor Author

Dont make a constant use the identity system to just check if they are in the role PII, it creates roles based on the flag enum

I'm not sure I understand what you mean, is it just bad to do this or is it not supposed to work?

@Geekyhobo
Copy link
Contributor

Dont make a constant use the identity system to just check if they are in the role PII, it creates roles based on the flag enum

I'm not sure I understand what you mean, is it just bad to do this or is it not supposed to work?

image
You can just do the above and not make it a const (Dont make it a const) Falgs are automatically converted from the adminflags enum to be attached to your "identity" on the site that picture was taken form the bans index if you are curious

@NullWanderer
Copy link
Contributor Author

Dont make a constant use the identity system to just check if they are in the role PII, it creates roles based on the flag enum

I'm not sure I understand what you mean, is it just bad to do this or is it not supposed to work?

image You can just do the above and not make it a const (Dont make it a const) Falgs are automatically converted from the adminflags enum to be attached to your "identity" on the site that picture was taken form the bans index if you are curious

PJB requested I make this a constant, thats why I did. Unless I completely misunderstood what she meant
image

@Geekyhobo
Copy link
Contributor

I have no idea, ima jsut let pjb reveiw

Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good so far.

@NullWanderer NullWanderer marked this pull request as ready for review June 11, 2024 02:12
@NullWanderer
Copy link
Contributor Author

I have no idea how I could keep the ban autofill stuff working without leaking PII to the client, or making spaghetti by turning the button into a checkbox

I just opted to disable it for now, hoping someone else might have a better idea
image

@NullWanderer NullWanderer requested a review from PJB3005 June 11, 2024 02:13
@NullWanderer
Copy link
Contributor Author

NullWanderer commented Jun 11, 2024

image

@PJB3005 PJB3005 merged commit 92aceb8 into space-wizards:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PII should be hidden to anyone without the PII permission
3 participants