Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI breaks easily around crates #1252

Closed
SweptWasTaken opened this issue Jul 2, 2020 · 2 comments
Closed

AI breaks easily around crates #1252

SweptWasTaken opened this issue Jul 2, 2020 · 2 comments
Labels
P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes

Comments

@SweptWasTaken
Copy link
Contributor

Crates seem to break the AI pretty easily.

[ERRO] job: Job failed on exception:
System.OperationCanceledException: The operation was canceled.
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at Content.Server.GameObjects.EntitySystems.JobQueues.Job`1.ProcessWrap() in C:\Users\Desktop\GitHub\space-station-14\Content.Server\GameObjects\EntitySystems\JobQueues\Job.cs:line 167
[ERRO] unobserved: System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (The operation was canceled.)
 ---> System.OperationCanceledException: The operation was canceled.
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at Content.Server.GameObjects.EntitySystems.JobQueues.Job`1.ProcessWrap() in C:\Users\Desktop\GitHub\space-station-14\Content.Server\GameObjects\EntitySystems\JobQueues\Job.cs:line 167
   --- End of inner exception stack trace --- 

Kept getting the above exception while having a couple AI chase me through a bunch of crates I had strewn about. Couldn't pin down an exact cause, I think the crates just sorta break the AIs pathing because once I got this exception the AI would just stop moving and wouldn't come back.

Also, AI won't open the crates to attack you if you're hiding in them. They could just open them but instead they'll just bang away at the outside of the crate.

@metalgearsloth

@metalgearsloth
Copy link
Contributor

Crates are ignored for pathfinding and they would only be used for collision avoidance.

I'm not 100% on the cause but when the pathfinding is cancelled it can throw an exception if the game's lagging. I tried a few different things but didn't seem to be able to resolve it as I don't know enough about Tasks.

@ShadowCommander ShadowCommander added Area: Entities P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes labels Jul 7, 2020
@SweptWasTaken
Copy link
Contributor Author

Pretty sure this was fixed by the above pr.

rbertoche pushed a commit to rbertoche/space-station-14 that referenced this issue Mar 16, 2023
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this issue May 2, 2024
* asteroids

* frontier bg and neb

* accidental double same layer

* revert default to true default

was used as testing since frontier's parallax wasn't actually set to the correct .yml due to mapping issues
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this issue May 2, 2024
DoutorWhite pushed a commit to rbertoche/space-station-14 that referenced this issue Jun 17, 2024
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this issue Nov 21, 2024
# Description

This fixes some stupid math. Power attacks are now correctly slower than
left clicks. Previously they were faster.

# Changelog

:cl:
- fix: Power Attacks now correctly apply a penalty on swing speed, and
are no longer faster than left clicking.
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this issue Nov 21, 2024
iaada pushed a commit to iaada/space-station-14 that referenced this issue Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

No branches or pull requests

3 participants