Adds the thermo-electric generator #18840

PJB3005 · 2023-08-07T22:38:08Z

About the PR

Holy fuck it real.

Media

Content.Client_ldp8qd6RlI.mp4

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

add: Nanotrasen finally decided to give engineering departments something to do, and has finalized the schematics for the thermo-electric generator (TEG).
add: The TEG creates power by exchanging energy between a hot and cold gas on its two sides.
tweak: You can turn on gas heaters/freezers with alt-click now.
tweak: You can open air alarm and pump menus with activate (E) now.

Connects via node group.

Make it work properly when mapped.

Now uses a fixed supplier with a custom ramping system.

Removed separate Enabled bool from the component that always matched the power receiver's state. This enables adding a PowerSwitch component to give us alt click/verb menu.

github-actions · 2023-08-07T22:38:59Z

RSI Diff Bot; head commit 12e5a68 merging into 61bf951
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Markers/teg_arrow.rsi

State	Old	New	Status
arrow			Added

Resources/Textures/Structures/Machines/computers.rsi

State	Old	New	Status
sensors			Added

Resources/Textures/Structures/Power/Generation/teg.rsi

State	Old	New	Status
circ-0-light			Added
circ-0			Added
circ-1-light			Added
circ-1			Added
circ-2-light			Added
circ-2			Added
teg-oc00			Added
teg-oc01			Added
teg-oc10			Added
teg-oc11			Added
teg-op1			Added
teg-op10			Added
teg-op11			Added
teg-op2			Added
teg-op3			Added
teg-op4			Added
teg-op5			Added
teg-op6			Added
teg-op7			Added
teg-op8			Added
teg-op9			Added
teg			Added
teg_mid			Added

Edit: diff updated after 12e5a68

mirrorcult · 2023-08-07T22:41:08Z

for real tegheads only

mirrorcult · 2023-08-07T22:43:49Z

conflicts slightly with #18831 probably

Content.Server/Power/Generation/Teg/TegSensorData.cs

Partmedia · 2023-08-08T01:09:21Z

Content.Server/Atmos/Piping/Binary/EntitySystems/GasPressurePumpSystem.cs

The change to this file looks like it can be merg now

I'm not sure what you mean?

make separate pr for it or something (we need this now!!!!)

I went insane while starting my TEG every time on my test map so that's why it's here. Can't be arsed to cherry pick it. In fact, more coming up...

Partmedia · 2023-08-08T01:11:16Z

Content.Server/Atmos/Piping/Unary/Components/GasThermoMachineComponent.cs

+        /// Last amount of energy added/removed from the attached pipe network
+        /// </summary>
+        [DataField("lastEnergyDelta")]
+        [ViewVariables(VVAccess.ReadWrite)]


Does this need to be RW? It looks like it should be read-only since it's written to only in the ThermoMachineSystem

RW should be default for components IMO. Sure it's not useful, but having to pick and choose is meh.

github-actions · 2023-08-10T08:52:54Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Content.Server/Atmos/Piping/Unary/EntitySystems/GasThermoMachineSystem.cs

deltanedas · 2023-08-11T21:55:04Z

Content.Shared/SensorMonitoring/SharedSensorMonitoringConsoleComponent.cs

+    /// <summary>
+    /// A value in the range 0-1.
+    /// </summary>
+    /* L + */ Ratio,


Resources/Locale/en-US/devices/device-network.ftl

deltanedas · 2023-08-11T22:27:07Z

funny crash when deleting/deconstructing things linked to a sensor monitor console
wrap the thing in Exists(uid) first

Unhandled exception. System.Collections.Generic.KeyNotFoundException: Entity 46476 does not have a component of type Content.Server.DeviceNetwork.Components.DeviceNetworkComponent
   at Content.Server.SensorMonitoring.SensorMonitoringConsoleSystem.AtmosUpdate(EntityUid uid, SensorMonitoringConsoleComponent comp, AtmosDeviceUpdateEvent args) in Content.Server/SensorMonitoring/SensorMonitoringConsoleSystem.cs:line 293
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass47_0`2.<SubscribeLocalEvent>g__EventHandler|0(EntityUid uid, IComponent comp, TEvent& args) in RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 255
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass58_0`1.<EntSubscribe>b__0(EntityUid uid, IComponent comp, Unit& ev) in RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 393
   at Robust.Shared.GameObjects.EntityEventBus.EntDispatch(EntityUid euid, Type eventType, Unit& args, Boolean dispatchByReference) in RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 554
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalEventCore(EntityUid uid, Unit& unitRef, Type type, Boolean broadcast, Boolean byRef) in RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 222
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalEvent[TEvent](EntityUid uid, TEvent args, Boolean broadcast) in RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 182
   at Robust.Shared.GameObjects.EntitySystem.RaiseLocalEvent[TEvent](EntityUid uid, TEvent args, Boolean broadcast) in RobustToolbox/Robust.Shared/GameObjects/EntitySystem.cs:line 150
   at Content.Server.Atmos.EntitySystems.AtmosphereSystem.ProcessAtmosDevices(GridAtmosphereComponent atmosphere) in Content.Server/Atmos/EntitySystems/AtmosphereSystem.Processing.cs:line 339
   at Content.Server.Atmos.EntitySystems.AtmosphereSystem.UpdateProcessing(Single frameTime) in Content.Server/Atmos/EntitySystems/AtmosphereSystem.Processing.cs:line 478
   at Content.Server.Atmos.EntitySystems.AtmosphereSystem.Update(Single frameTime) in Content.Server/Atmos/EntitySystems/AtmosphereSystem.cs:line 71
   at Robust.Shared.GameObjects.EntitySystemManager.TickUpdate(Single frameTime, Boolean noPredictions) in RobustToolbox/Robust.Shared/GameObjects/EntitySystemManager.cs:line 303
   at Robust.Shared.GameObjects.EntityManager.TickUpdate(Single frameTime, Boolean noPredictions, Histogram histogram) in RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 272
   at Robust.Server.GameObjects.ServerEntityManager.TickUpdate(Single frameTime, Boolean noPredictions, Histogram histogram) in RobustToolbox/Robust.Server/GameObjects/ServerEntityManager.cs:line 153
   at Robust.Server.BaseServer.Update(FrameEventArgs frameEventArgs) in RobustToolbox/Robust.Server/BaseServer.cs:line 718
   at Robust.Server.BaseServer.<SetupMainLoop>b__66_1(Object sender, FrameEventArgs args) in RobustToolbox/Robust.Server/BaseServer.cs:line 535
   at Robust.Shared.Timing.GameLoop.Run() in RobustToolbox/Robust.Shared/Timing/GameLoop.cs:line 228
   at Robust.Server.BaseServer.MainLoop() in RobustToolbox/Robust.Server/BaseServer.cs:line 562
   at Robust.Server.Program.ParsedMain(CommandLineArgs args, Boolean contentStart, ServerOptions options) in RobustToolbox/Robust.Server/Program.cs:line 78
   at Robust.Server.Program.Start(String[] args, ServerOptions options, Boolean contentStart) in RobustToolbox/Robust.Server/Program.cs:line 46
   at Robust.Server.ContentStart.Start(String[] args) in RobustToolbox/Robust.Server/ContentStart.cs:line 10
   at Content.Server.Program.Main(String[] args) in Content.Server/Program.cs:line 9

PJB3005 · 2023-08-12T00:27:27Z

funny crash when deleting/deconstructing things linked to a sensor monitor console
wrap the thing in Exists(uid) first

That wouldn't be a good fix. Best I can do is a TODO.

That said you reminded me there's similar bugs with the TEG itself. Crap.

PJB3005 · 2023-08-12T00:28:51Z

FYI @deltanedas the sensor monitoring console would still need a ton of work to make it... actually mappable. There's a reason it's so short-sighted, half-assed and filled with TODOs. I'm not intending to finish it in this PR.

deltanedas · 2023-08-12T06:52:27Z

even if it shouldnt be mapped its possible an admeme might spawn it, letting someone easily crash server is bad

Emisse · 2023-08-12T06:54:28Z

if an admin is dumb enough to spawn it we can just yell at them

PJB3005 · 2023-08-12T07:23:25Z

Opening it would shit up the server's network connection in its current state.

PJB3005 · 2023-08-12T08:14:28Z

you mean like this?

Use TimedDespawn instead. The "no show in right-click menuu" goes into a new general-purpose component. Thanks Julian.

…nsole.

PJB3005 · 2023-08-12T09:10:27Z

That said you reminded me there's similar bugs with the TEG itself. Crap.

Wait that was also sensor monitoring. My bad.

Fixed rotation on GuideEntityEmbed not working correctly. Added Margin property to GuideEntityEmbed

So it doesn't appear in the guidebook and spawn menu.

This reverts commit a242af5.

PJB3005 added 16 commits July 29, 2023 15:00

Basic TEG start.

249e294

Connects via node group.

Basic TEG test map

07b3f86

Sensor monitoring basics, TEG circulator flow

0b69a64

Basic power generation (it doesn't work)

a75366b

Merge branch 'master' into 23-07-29-teg

4f25499

More sensor monitoring work

ec4c2ef

Battery (SMES) monitoring system.

25da043

Sensor monitoring fixes

fa3283a

Make it work properly when mapped.

Test map improvements

f4be0d6

Revise TEG power output mechanism.

9bbb765

Now uses a fixed supplier with a custom ramping system.

TEG test map fixes

2f8a6cd

Make air alarms and pumps open UI on activate.

033698f

Clean up thermo machines power switch.

fba5870

Removed separate Enabled bool from the component that always matched the power receiver's state. This enables adding a PowerSwitch component to give us alt click/verb menu.

TEG but now fancy

ffb736a

Make sensor monitoring console obviously WiP to mappers.

b9a1f03

Vending machine sound, because of course.

98fba4c

github-actions bot added Changes: Map Changes: Might require knowledge of mapping. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. labels Aug 7, 2023

PJB3005 changed the title ~~Basic TEG start.~~ Adds the thermo-electric generator Aug 7, 2023

Just-a-Unity-Dev mentioned this pull request Aug 7, 2023

Adds the TEG #18102

Closed

5 tasks

moonheart08 reviewed Aug 7, 2023

View reviewed changes

Content.Server/Power/Generation/Teg/TegSensorData.cs Show resolved Hide resolved

Partmedia reviewed Aug 8, 2023

View reviewed changes

PJB3005 added 2 commits August 8, 2023 21:36

Merge remote-tracking branch 'upstream/master' into 23-07-29-teg

1c6b57e

Terrible, terrible graph background color

094e130

PJB3005 requested a review from Emisse as a code owner August 11, 2023 21:37

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted labels Aug 11, 2023

Merge remote-tracking branch 'upstream/master' into 23-07-29-teg

a105ea5

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 11, 2023

deltanedas suggested changes Aug 11, 2023

View reviewed changes

Get rid of the TegCirculatorArrow logic.

566cbd9

Use TimedDespawn instead. The "no show in right-click menuu" goes into a new general-purpose component. Thanks Julian.

PJB3005 requested a review from ElectroJr as a code owner August 12, 2023 08:40

PJB3005 added 2 commits August 12, 2023 10:44

Put big notice of "not ready, here's why" on the sensor monitoring co…

c980d84

…nsole.

TryGetComponent -> TryComp

7002c72

PJB3005 added 4 commits August 12, 2023 11:14

Lol there's a HideContextMenu tag

b4c2918

Test fixes

bb45251

Guidebook for TEG

9f2301a

Fixed rotation on GuideEntityEmbed not working correctly. Added Margin property to GuideEntityEmbed

Make TEG power bar default to invisible.

d110b90

So it doesn't appear in the guidebook and spawn menu.

PJB3005 requested a review from EmoGarbage404 as a code owner August 12, 2023 20:20

Merge remote-tracking branch 'upstream/master' into 23-07-29-teg

12e5a68

moonheart08 merged commit a242af5 into space-wizards:master Aug 12, 2023

PJB3005 deleted the 23-07-29-teg branch August 12, 2023 20:43

metalgearsloth mentioned this pull request Aug 13, 2023

TEG code actually needs reviewing #19037

Open

metalgearsloth added a commit to metalgearsloth/space-station-14 that referenced this pull request Aug 13, 2023

Revert "Adds the thermo-electric generator (space-wizards#18840)"

4cd832c

This reverts commit a242af5.

slarticodefast mentioned this pull request Dec 23, 2024

Remove deprecated sensor monitoring console #34032

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds the thermo-electric generator #18840

Adds the thermo-electric generator #18840

PJB3005 commented Aug 7, 2023

github-actions bot commented Aug 7, 2023 •

edited

Loading

mirrorcult commented Aug 7, 2023

mirrorcult commented Aug 7, 2023

Partmedia Aug 8, 2023

PJB3005 Aug 8, 2023

deltanedas Aug 8, 2023

PJB3005 Aug 8, 2023

Partmedia Aug 8, 2023

PJB3005 Aug 8, 2023

github-actions bot commented Aug 10, 2023

deltanedas Aug 11, 2023

deltanedas commented Aug 11, 2023

PJB3005 commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

deltanedas commented Aug 12, 2023

Emisse commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

Adds the thermo-electric generator #18840

Adds the thermo-electric generator #18840

Conversation

PJB3005 commented Aug 7, 2023

About the PR

github-actions bot commented Aug 7, 2023 • edited Loading

mirrorcult commented Aug 7, 2023

mirrorcult commented Aug 7, 2023

Partmedia Aug 8, 2023

Choose a reason for hiding this comment

PJB3005 Aug 8, 2023

Choose a reason for hiding this comment

deltanedas Aug 8, 2023

Choose a reason for hiding this comment

PJB3005 Aug 8, 2023

Choose a reason for hiding this comment

Partmedia Aug 8, 2023

Choose a reason for hiding this comment

PJB3005 Aug 8, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 10, 2023

deltanedas Aug 11, 2023

Choose a reason for hiding this comment

deltanedas commented Aug 11, 2023

PJB3005 commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

deltanedas commented Aug 12, 2023

Emisse commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

PJB3005 commented Aug 12, 2023

github-actions bot commented Aug 7, 2023 •

edited

Loading