Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide syndicate channel from examine #19848

Closed
wants to merge 6 commits into from

Conversation

deltanedas
Copy link
Contributor

About the PR

syndicate radio channel is hidden from examine of most headsets
still visible when examining blood-red headset and encryption key

also fix grammar of blood-red key

Why / Balance

makes it harder for trollers doing random cavity searches to put someone in perma for having valid radio channel, now they really need to bust their ass and get a screwdriver

Technical details

adds hidden field to the radio channel prototype, which is true for syndicate channel
adds showHidden field to encryption key holder so when it makes sense it can be shown (blood-red headset is already valid so no use hiding it)

i think due to how radio works a malf client could just show it anyway since im pretty sure the examine is done clientside

Media

cant see sus channel in examine:
11:40:48

blood-red headset is valid so dont bother hiding:
11:52:17

new players need to see :t so dont hide it:
11:52:26

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • tweak: The syndicate radio channel is hidden when examining headsets.

@deltanedas deltanedas changed the title Sneaky headset hide syndicate channel from examine Sep 5, 2023
@Partmedia
Copy link
Contributor

Since you've started splitting up your refactoring/content commits, your PRs have been much easier to understand and review. I've looked through the code and it looks good. I'll give this a test in-game soon.

@Partmedia Partmedia self-assigned this Sep 5, 2023
@EmoGarbage404
Copy link
Contributor

this seems really confusing? How would new players know what key corresponds to the syndie channel? If someone has their hands on your headset they should be more than able to determine if there's a syndie channel in it.

@deltanedas
Copy link
Contributor Author

they can determine it by examining the key, which is explicitly left in for new players
and they still can they just have to screw it

@misandrie
Copy link
Contributor

Probably should be made into a TraitorKnowledge component, since there are other stealth items which need their status hidden from non-traitors (ex. Hypopen and its contents)

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 6, 2023

Probably should be made into a TraitorKnowledge component, since there are other stealth items which need their status hidden from non-traitors (ex. Hypopen and its contents)

can have the key memorise who inserted it and allow that person to see the channel

@misandrie
Copy link
Contributor

Probably should be made into a TraitorKnowledge component, since there are other stealth items which need their status hidden from non-traitors (ex. Hypopen and its contents)

can have the key memorise who inserted it and allow that person to see the channel

I'd say that traitors should know and spot traitor stealth items to see then for what they are to recognize each other.

@metalgearsloth
Copy link
Contributor

Probably should be made into a TraitorKnowledge component, since there are other stealth items which need their status hidden from non-traitors (ex. Hypopen and its contents)

can have the key memorise who inserted it and allow that person to see the channel

I'd say that traitors should know and spot traitor stealth items to see then for what they are to recognize each other.

Traitor mobs shouldn't have innate skills.

@misandrie
Copy link
Contributor

Probably should be made into a TraitorKnowledge component, since there are other stealth items which need their status hidden from non-traitors (ex. Hypopen and its contents)

can have the key memorise who inserted it and allow that person to see the channel

I'd say that traitors should know and spot traitor stealth items to see then for what they are to recognize each other.

Traitor mobs shouldn't have innate skills.

Crew shouldn't know that a pen actually also has a chemical container in it and that you can stab with it either. Limiting knowledge of traitor gear to only traitors (and maybe hos/captain, but that's another topic) seems reasonable and logical. A security officer going "this guy had a hypopen/voicemask/thieving gloves" sounds and looks ridiculous.

@lzk228
Copy link
Contributor

lzk228 commented Sep 6, 2023

How would new players know what key corresponds to the syndie channel?

why do syndicate technologies should be new players-friendly?

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 6, 2023

How would new players know what key corresponds to the syndie channel?

why do syndicate technologies should be new players-friendly?

where would new players get the knowledge on how to use them? ask in common radio?

@misandrie
Copy link
Contributor

How would new players know what key corresponds to the syndie channel?

why do syndicate technologies should be new players-friendly?

where would new players get the knowledge on how to use them? ask in common radio?

Shift-click on key

Or shove it into uplink desc
Or add a note to the kit telling how to use it
Or shove it into the guidebook

@lzk228
Copy link
Contributor

lzk228 commented Sep 6, 2023

instead of selling 2 keys in uplink, put 2 keys and paper with instructions in box, and selling box
or write it in key/headset description in uplink

@deltanedas
Copy link
Contributor Author

real question is why would you want to hide :t for Syndicate channel on the... blood-red encryption key
doing so would only hurt noob syndies which already are a laughing stock, not knowing how to use their funny radio would just make it worse for them
people that know how to use it also know that the key itself is valid so no reason to hide it

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 6, 2023

How would new players know what key corresponds to the syndie channel?

why do syndicate technologies should be new players-friendly?

where would new players get the knowledge on how to use them? ask in common radio?

Shift-click on key

Or shove it into uplink desc Or add a note to the kit telling how to use it Or shove it into the guidebook

people may just not read it, and an entire note seems excessive
i'd still say making the key remember who inserted it is the best option, though just shoving it into the description/a note is much easier to implement, so yes, WYCI moment

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 6, 2023

real question is why would you want to hide :t for Syndicate channel on the... blood-red encryption key doing so would only hurt noob syndies which already are a laughing stock, not knowing how to use their funny radio would just make it worse for them people that know how to use it also know that the key itself is valid so no reason to hide it

yeah of course the key itself should definitely show channel

@misandrie
Copy link
Contributor

real question is why would you want to hide :t for Syndicate channel on the... blood-red encryption key doing so would only hurt noob syndies which already are a laughing stock, not knowing how to use their funny radio would just make it worse for them people that know how to use it

Noob syndies try to plant c4 on fuel tanks, theres a bigger issue as to why they're a laughing stock than the :t hidden from headset inspect.

also know that the key itself is valid so no reason to hide it

If a secoff is armed with a screwdriver without probable cause and uses it to check headsets that's an administrative issue.

@LankLTE
Copy link
Contributor

LankLTE commented Sep 6, 2023

I don’t really see the problem this is trying to solve. If they can shift click on your radio they can spend literally one second pulling out the keys. This also makes it inconsistent from every other key (ie. a traitor stealing command keys), I agree with emo that someone who has your radio should be able to tell what channels it can access.

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 6, 2023

I don’t really see the problem this is trying to solve. If they can shift click on your radio they can spend literally one second pulling out the keys. This also makes it inconsistent from every other key (ie. a traitor stealing command keys), I agree with emo that someone who has your radio should be able to tell what channels it can access.

shiftclicking radio in examine screen

@LankLTE
Copy link
Contributor

LankLTE commented Sep 6, 2023

shiftclicking radio in examine screen

I know that, I mean this doesn’t change the fact that you can unscrew the keys from it in about a second, making this change pointless

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 6, 2023

shiftclicking radio in examine screen

I know that, I mean this doesn’t change the fact that you can unscrew the keys from it in about a second, making this change pointless

you would need to actually take and inspect the headset as opposed to simply examining it in-inventory

@EmoGarbage404
Copy link
Contributor

If the issue is people examining from the stripping menu, then fix that. Otherwise, you're just introducing inconsistent behavior.

This is just further compounded by the fact that examining it is the sole way of determining what keys are inserted. I could see a lot of people being confused if inserting the key into the headset has no immediate feedback.

Also, calling new players bad at the game isn't a justification for making things harder for them. Consider having some perspective for those who aren't as experienced.

@deltanedas
Copy link
Contributor Author

deltanedas commented Sep 6, 2023

i am not aware of stripping thing this is for people strip searching and just by chance examining a headset
tested it and you cant see channels when examining so this cant even affect that

this shouldnt make anything harder since the key itself still shows that its :t for syndicate channel

@EmoGarbage404
Copy link
Contributor

If you're getting your belongings searched, they should be able to see what channels you have access to? This feels dumb.

@deltanedas
Copy link
Contributor Author

may as well label chameleon clothing chameleon at that point

@LankLTE
Copy link
Contributor

LankLTE commented Sep 6, 2023

may as well label chameleon clothing chameleon at that point

It’s pretty widely agreed that if you have something like chameleon clothes or agent IDs in your hands you should be able to tell they’re different than normal- this shouldn’t be any different. You still need to get it in your hand, and it’s hardly any more effort than unscrewing it.

@deltanedas
Copy link
Contributor Author

ok fake gamers

@deltanedas deltanedas closed this Sep 6, 2023
@misandrie
Copy link
Contributor

shoe checkers keep on winning

@deltanedas deltanedas deleted the sneaky-headset branch April 3, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants