Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to delay uplink item purchase #20214

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

Titian3
Copy link
Member

@Titian3 Titian3 commented Sep 15, 2023

About the PR

Added a timeout(Out of stock time) for uplink items to delay being purchased to mechanical preventions for massive station damage or for balancing better items to come later in the round.
Mainly right now its to add a delay to the syndicate bomb for 30min from round start.

Why / Balance

Many discussions about if the syndicate bomb is station sabotage and needs some rule preventions this should be a mechanical way to balance it.
Latest one:
https://forum.spacestation14.io/index.php?/topic/2806-syndicate-bombs-early-into-the-round/

Technical details

Changes to the client store UI to allow prevent purchase of items before round time has reached timeout defined on listing prototype yml.

Media

UplinkDelay.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Shouldn't be any breaking changes.

Changelog
Uplink items can now have a delay set on them in the uplink to mechanically prevent purchases for game balance.

🆑Repo

  • add: Time out for particular uplink items for balancing. Syndicate Bomb can only be purchased after 30min.

@github-actions github-actions bot added the Changes: UI Changes: Might require knowledge of UI design or code. label Sep 15, 2023
@LankLTE
Copy link
Contributor

LankLTE commented Sep 15, 2023

syndie bombs are 11TC so you cant even buy two without a second traitor, and if you have a second traitor you dont have the out of stock time, so this will only really effect syndies who butcher renault

The point is to prevent people from buying syndie bombs 5 minutes into a round and causing massive damage. This is a good change.

@Aisu9
Copy link
Contributor

Aisu9 commented Sep 15, 2023

this will also prevent players from committing the error of mass sabotage before the 30 minutes mark(because yes spacing a giant area with a 53% probability is still mass sabotage)

@deltanedas
Copy link
Contributor

deltanedas commented Sep 15, 2023

53% if someone bothers defusing it****

no reason to not have this roundstart syndicate bombing is horrible

@Chief-Engineer
Copy link
Contributor

partially completes a point of #20064

@Partmedia Partmedia mentioned this pull request Sep 16, 2023
1 task
@Titian3 Titian3 marked this pull request as ready for review September 17, 2023 17:26
@Titian3
Copy link
Member Author

Titian3 commented Sep 17, 2023

I was going to wait a little until I had a better version of this but it is almost every game it negatively affects most roles gameplays and this should fix that for now.
Main issues hadn't fixed yet were that the timer update/refresh on the listing page is manual instead of an auto one and this may affect nukies purchasing it but they get a lot already.

Copy link
Contributor

@LankLTE LankLTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to master to fix the tests failing

@Titian3
Copy link
Member Author

Titian3 commented Sep 19, 2023

Please update to master to fix the tests failing

Updated to latest master and ran again, it failed but looking at the test it passes on my local for that same test, on window.
image

image

Flakey test?

@LankLTE
Copy link
Contributor

LankLTE commented Sep 19, 2023

I believe this test fail is a different (unrelated) issue.

@LankLTE LankLTE merged commit 41139bf into space-wizards:master Sep 19, 2023
@Chief-Engineer Chief-Engineer mentioned this pull request Sep 15, 2023
31 tasks
BasedUser pushed a commit to cube-station-14/cube-station-14 that referenced this pull request Oct 6, 2023
* Time delay for certain uplink stock.

* Remove glitchy timer and add refresh button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Changes: Might require knowledge of UI design or code.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants