Prevent willful deconversion of Revolutionaries

[Krunklehorn]

About the PR

Prevents converted Revolutionaries from using mind-shield implants to deconvert themselves.

Head Revolutionaries are unaffected and may still choose to break the implant on themselves.

Why / Balance

Issue #20064 aims to convert rules to mechanics. Willful deconversion seems like a unanimously ahelpable event as Revolutionaries have no in-character reason to justify betraying the revolution.

This change does not prevent players from choosing to forgo Revolutionary responsibilities, it simply prevents them from giving themselves a free pass to do so. It also prevents such people from giving themselves a justification to act against the Revolution should they encounter it's members again, later.

Even if one argued a Rev could set up some disaster and then convert themselves on purpose to avoid heat, deconversion does not trigger NLR. A character would remember all of their actions and would know how to thwart whatever plans were set in motion, or at least warn others.

Technical details

SharedRevolutionarySystem responds to AddImplantAttemptEvent to determine if the implant should fail.

PopupAfterFailedImplantEvent was added to allow a system to override what message is displayed to a user when an implant fails. SharedRevolutionarySystem uses it to display the message, "You cannot bring yourself to betray the revolution!"

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog

🆑 Krunk

• tweak: Converted Revolutionaries can no longer willfully de-convert themselves with a mind-shield.

[MACMAN2003]

deconversion doesn't trigger NLR?

[Rainbeon]

deconversion doesn't trigger NLR?

It does not

[LordCarve]

This is simple yet very well thought-out. There really is zero in-character incentive to do it. Great change!

[FairlySadPanda]

This allows Sec to ID Revs outside the rule limits. Moot point as Revs is dead at the moment.

[LordCarve]

This allows Sec to ID Revs outside the rule limits.

How exactly? Officer gives some stranger an implanter and says "use it on yourself"?
How do they differentiate whether the person can't do it or just doesn't want to do it?

All the feedback they get is they aren't doing it. It just means "the person isn't cooperating" and uncooperative non-revs are aplenty.

[deltanedas]

vs just stun cuff and inject mindshield like a good little secoff

[metalgearsloth]

Given revs were disabled bandaid prs aren't being merged at this time pending a full revs rework.