-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes various tool shapes and makes the utility/sec belt accommodate them. #26069
Conversation
i dont think this is very interesting |
I think it's cool we're playing around with the grid system, but if the primary purpose is to dissuade non-engineers from carrying a full set of tools...well...utility belts can be printed at lathes. Even if I'm a passenger, I can spend a few minutes getting cloth and just toss it at cargo. 9/10 players will make me a belt if I give them the resource. As for security... you're gonna wanna make the same change to chest rigs, too. |
Wrench and welder feels cursed but I'm intriuged by the crowbar and baton |
chest rigs can hold any item rather than just security items, so they have an advantage already. |
still gives several extra steps required to efficiently carry them around. |
All this pr will do is just make the lives of anyone who regularly carries these items more miserable. The only thing that's maybe passable is the welder, but making these items take up more space without any kind of compromise is silly. This'd be more understandable if this wasn't explicitly an objectively bad change. |
It makes zero sense for a crowbar to be the same size as a screwdriver, and the screwdriver/wirecutters shouldn't be tiny items. Not everyone needs to be carrying a full set of tools around at all times, so making them harder to carry around without a toolbelt is what I'm trying to do here.
What are you even trying to say here? This isn't objectively anything, and there's definitely room for discussion about it as well so it isn't explicitly anything either. |
This doesn't make sense. Given what you use each tool for, the wrench should not be changed, and the crowbar at MOST should be 3 tiles. A wrench, wire cutter, and screwdriver should stay as they are, and the welder and crowbar are passable. The baton at most should be 3 as well. 4 long is an incredibly inconvenient shape for practically anyone. |
Wrench is 3 because a wrench is larger than a screwdriver/wirecutters, crowbar is 4 because a crowbar is longer than a wrench. Welder is shaped like that for it's actual ingame shape, and the baton is 4 long because the item was 2x2 previously, which is 4 tiles of space in the inventory.
the crowbar is used to pry things and is long and thin for this reason, it makes sense that it's long. The welder is shaped like that because of it's actual shape. The wrench reasonably should be larger than a screwdriver and I wanted to have an extra tile of space used on one item besides the welder so there's not just a single empty space if you fill your toolbelt. |
The crowbar bit is understandable, but the wrench change isn't. If we wanna bring up the "makes sense" argument then changing the crowbar (a one handed item) and the baton (a one handed item) to be comically large is silly. They fit in belts. The wrench is a small item, there's no need to modify it. |
The baton isn't comically large, and neither is the crowbar. They're normal sized items from previously being small. I didn't make them 2x4 or 4x4, I made them 1x4. That's 4 tiles of space taken up, just like the baton used to as a square rather than a rod. You are aware that the lecter (a one handed item) is 4x4, right? Same as the laser rifle. The drozd is also 2x4 and one handed, as is the c20. The baton/crowbar are 1x4, half the size of that. Again, these items I've changed are not "comically large" they are normal sized, the size set in the files is literally called the "normal" size. |
I understand what you're trying to do here, but this just seems like a solution to an issue that doesn't exist imho. |
There needs to be an empty 4x4 grid on the utility belt so you can fit an RTG or a stack of Cabling while carrying every tool as an engineer, also the wrench being bigger makes no sense, its not a monkey wrench its a normal wrench for nuts and bolts |
i think this is overall bad for the game, it just makes toolbelts even more of a necessity |
i love it, makes the belt more dynamic and actually kind of fits the sprite now. The people complaining about this change are probably the kinds of people that store their giant tools in their duffle bag and want to optimise gameplay speed. They're tools, not meant to be super fast unlike a gun. For secbelt, it's probably faster now since there's a designated place for the baton and its bigger (reducing chance of misclicking) and the other objects are standard 1x2 |
I don't feel like this is a good addition |
pretty sure it was explicitly stated by a maintainer at one point (i may be misremembering) that the tools and toolbelts were to remain normalised shapes |
It's funny because toolbelts have items literally hanging off them on their sprites (batons on sec belts are quite long) But overall I don't really get what this pr is trying to solve; it's gonna be rather hell to investigate every sprite and making it conform to a shape, which would call into question standardised item sizes rework |
I think this might be more okay with #25834 |
i think this is fine. welding tool makes the most sense. i believe the grey crowbar used to be larger than the emergency red one, so maybe that should be brought back, making it only 1x3 or something. i guess the wrench is dubious, but i could definitely see most wrenches being larger and heavier than a screwdriver. i agree the belts being a weird shape is... unusual... but i dunno, its kinda fun, and it does fit the sprite. |
Overall maintainer opinion is dislike so going to reject it at this time. |
Let me know if there's any changes I coulf make for it to be reopened in the future. |
About the PR
The wrench, welder, crowbar, and baton now have unique sizes rather than the generic normal/small sizes.
The wrench is 1x3
the welder is the gun shape
the crowbar/baton are 1x4 and normal sized.
Why / Balance
How is a crowbar the same size as a screwdriver?
Now it's harder for non-engineers to carry an entire set of tools on them since most people don't have access to a utility belt.
Media
Breaking changes
Changelog
🆑